Repository navigation
Conversation
bmc08gt
force-pushed
the
feat/profile-refresh-edit-profile
branch
from
October 6, 2026 22:58
573f057 to
4943996
Compare
bmc08gt
added this pull request to stack #1696
October 7, 2026 01:28
bmc08gt
force-pushed
the
feat/profile-refresh-edit-profile
branch
from
October 7, 2026 01:51
4943996 to
4b999fb
Compare
bmc08gt
force-pushed
the
feat/profile-refresh-edit-profile
branch
from
October 7, 2026 01:56
4b999fb to
c265e38
Compare
bmc08gt
force-pushed
the
feat/profile-refresh-edit-profile
branch
from
October 7, 2026 02:40
c89e9d2 to
08c3e95
Compare
Cover, photo, name, username, bio and minimum to chat on one screen, each opening its editor. The You tab's Edit Profile opens it, and Settings loses its temporary Profile section. The username balance gate moves from features/menu to shared/userflags so both screens use it.
The exported file is now "Chat with <name>", or "Profile Card" when the profile has no name, instead of one derived from the card signature.
… tests Sanitise the display name before building the profile card file name, so a name of only hostile characters falls back to "Profile Card" instead of "Chat with ". Cover the upload failure paths, the username row's gate, and clearing a bio with tests. Drop the unused My Account row strings and the ic_profile_picture drawable, and correct the TipCodeExportStorage KDoc.
Match EditBioScreen.swift: a centred title, the field 20dp under the bar in textLarge (iOS appDisplayXS, 20pt bold), the counter directly under the field with any error below it, and Save 20dp off the bottom. The 8pt gaps round to the 5dp static grid.
Checked against iOS EditProfileScreen.swift and ChangeCoverPictureScreen.swift: - The cover editor is titled "Cover", sits 20dp under the bar instead of centred, and uses the banner's placeholder fill with a secondary plus. - Replacing a cover saves without the "Change Cover?" prompt. iOS only confirms a replacement avatar, so the avatar keeps its prompt and the two unused cover prompt strings go. - Save sits 20dp from the bottom on both pickers, as on iOS. - Edit Profile's "Change cover" chip frosts the cover behind it, like iOS's glass CoverChip, and takes iOS's sentence case. - The camera badge sits 6dp right and 2dp down off the avatar, as iOS offsets it. - "Minimum to Chat" takes iOS's casing.
bmc08gt
force-pushed
the
feat/profile-refresh-edit-profile
branch
from
October 7, 2026 03:04
08c3e95 to
da93a90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth slice of the profile refresh, matching code-payments/code-ios-app#988: Edit Profile replaces the temporary Profile section in Settings, and you can now set a bio and a cover picture. Stacked on #1692.
Edit Profile (
features/myaccount, Figma frame around node 10961:185)startChattingFeefor yourself, so it falls back to the regional default like the You tab.Bio (
features/user-profile)BioDraftcounts code points, so an emoji counts once. 160 is the limit, a blank bio over a non-blank one is a valid save, and an unchanged bio can't be saved.SetBioError.FailedModeratedandInvalidBioshow their own errors; editing clears them.Cover picture
UpdateProfileStep.Coverreuses the photo picker with aSlot(Avatar or Cover) passed in when the view model is created, so a cover upload can never land on the avatar. The preview uses the banner shape fromProfileCover.Keyboard focus
RequestFocusWhenSettled), instead of during the slide.Profile card export
Tests
BioDraftTest,EditBioViewModelTest(including clearing a bio),EditProfileViewModelTest(including each branch of the username gate),PhotoSelectionViewModelTest(slot isolation and the cover and avatar rejection alerts),ProfileCardViewModelTestandTipCodeExportNameTest.UsernameGateand its test move touserflagsso Menu and Edit Profile share it.