Repository navigation
feat(analytics): catalogue the profile refresh events - #1698
Merged
Merged
Conversation
Adds a Profile domain: Settings Viewed, Edit Profile Viewed, Field Saved, Bio Moderation Failed, Menu Action, Pinned Button Tapped and Card Shown, with ProfileField, ProfileMenuAction and ProfilePinnedAction lists. Adds PROFILE to AddMoneySource. No call sites are wired yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Profile domain to the analytics catalogue for the profile refresh (#1689, #1691–#1694), and a
Profilevalue onAddMoneySource.Events: Settings Viewed, Edit Profile Viewed, Field Saved (
Field), Bio Moderation Failed, Menu Action (Action: Mute, Report, Block, Unblock), Pinned Button Tapped (Action: Start Chatting, Open Chat, Unblock), and Card Shown.Nothing sends these yet. The profile slices pass
AddMoneySource.CHATfor an add-money started from a profile, and switch toPROFILEonce this lands; the call sites follow in their own change.iOS has no profile events today, so the names are new rather than matched. The regenerated
AnalyticsEvents.swiftonly reaches iOS after a manual run of the shared-core publish workflow.