Repository navigation
feat(groups): refresh Edit Group with cover and description editors - #1705
Merged
Merged
Conversation
…between edit screens
…nd a confirm before every save
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the Edit Group refresh from code-ios-app #994. Stacked on #1703.
Edit Group was two rows, Picture and Name, because the comment there assumed
EditChatRequestonly carried a title and picture. It has carried cover and description since flipcash2 0.18.0, so the screen now matches iOS:New editors:
coverOnly).DescriptionEdit.Clear. A moderation refusal shows under the field and clears as soon as you type; other failures show a dialog.Every save (name, picture, cover, description) now asks "Change Group …?" first, through one shared
showGroupChangeConfirmation. It replaces the separate name and picture prompts;EditGroupConfirmationTestpasses unchanged.CoverAndPhoto,CameraBadgeandFieldCardmove from myaccount's Edit Profile into common-ui so both edit screens draw the same header. Edit Profile calls the shared versions with no visual change intended.Differences from iOS:
blobStorage.uploaddoes the whole upload in one call, so there's nothing to reserve and those iOS test cases aren't ported.GroupFieldonly has name and picture.Tests ported from iOS
EditGroupModelTests,EditGroupDescriptionModelTestsandGroupChangeDialogTests:EditGroupCoverViewModelTest,EditGroupDescriptionViewModelTest,GroupChangeDialogTest, plus cover and description cases inPartialEditsTest.