Skip to content

fix(profile): let content scroll under the pinned bar - #1706

Merged
bmc08gt merged 1 commit into
code/cashfrom
fix/profile-pinned-bar-scroll-edge
Oct 7, 2026
Merged

bmc08gt merged 1 commit into
code/cashfrom
fix/profile-pinned-bar-scroll-edge

Conversation

@bmc08gt

@bmc08gt bmc08gt commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

The person and group profiles stopped their content at the top edge of the pinned bar, because ProfilePinnedActionBar painted the screen background behind its buttons. On iOS the same bar is pinned with scrollEdgeBar(.bottom) (FlipcashUI/Modifiers/ScrollEdge.swift), so the page keeps scrolling underneath and fades out.

  • ProfilePinnedActionBar takes an optional HazeState. With one, it blurs what is under it using the composer's HazeMaterials.ultraThin over the background, with a progressive vertical gradient from clear at the bar's top edge to full at the bottom. Without one it keeps the solid background.
  • ChatProfileScreen and GroupProfileScreen move hazeSource from the header to the whole scroll viewport, so the bar has the members grid and requirements to blur. The top bar buttons already sampled the same state and now sample whatever scrolls under them as well.
  • GroupProfileScreen drops its bottom verticalScrollStateGradient fade, which ended at the bar's top edge and would have hidden the content the bar now shows.
  • common-ui picks up the haze bundle.

Scroll clearance and toast clearance are unchanged: the bar still reports its height, and the last row of the Moony group scrolls clear of Open Chat and Leave Chat.

@bmc08gt bmc08gt self-assigned this Oct 7, 2026
@github-actions github-actions Bot added the type: fix Bug fix label Oct 7, 2026
@bmc08gt
bmc08gt added this pull request to stack #1711 October 7, 2026 18:11
The pinned bar on the person and group profiles painted a solid
background, so the page stopped at its top edge. iOS pins the same bar
with scrollEdgeBar, where the content runs on underneath and fades out.

The bar now takes the screen's HazeState and blurs what is under it
with the composer's ultra-thin material, ramping from clear at its top
edge to full at the bottom. Both screens make the whole scroll viewport
the haze source instead of only the header, and the group profile drops
its bottom fade, which stopped the content above the bar.
@bmc08gt
bmc08gt force-pushed the fix/profile-pinned-bar-scroll-edge branch from f1bffde to f965241 Compare October 7, 2026 18:53
@bmc08gt
bmc08gt merged commit f8b3acf into code/cash Oct 7, 2026
3 checks passed
bmc08gt added a commit that referenced this pull request Oct 7, 2026
…e-token-card

* origin/code/cash:
  build: update release manifest
  fix(chat): run the emoji drawability check on the injected dispatcher (#1719)
  test(profile): stub the cover prefetch in the featured groups picker test (#1718)
  chore(contacts): drop the READ_CONTACTS permission (#1717)
  fix(chat): drop the empty band above the oldest message (#1716)
  fix(profile): let content show through behind the footer buttons (#1715)
  feat(chat): drop the card at the start of chat history (#1707)
  feat(ui): blur scroll content under the app bar on more screens (#1713)
  fix(profile): open looked-up people and featured groups on their profiles (#1709)
  fix(profile): let content scroll under the pinned bar (#1706)
  feat(chat): only members who can chat collect cash links (#1714)
  fix(tipping): floor group minimum balance at one cent (#1712)
  feat(profile): link a chat's token from its profile (#1708)
  fix(tokens): load the market cap explainer for tokens you don't hold (#1710)

# Conflicts:
#	apps/flipcash/features/messenger/src/main/kotlin/com/flipcash/app/messenger/internal/screens/profile/GroupProfileScreen.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant