Repository navigation
fix(profile): put the status chips on the cover beside the avatar - #1009
Merged
Merged
Conversation
A timed mute ("Muted until 12:15 PM") in the action row leaves too little
width for Edit Group and Share; on Android the same layout wrapped Edit
Group onto two lines and pushed Share off screen. Below the title was
ruled out because the mute state arrives after first render and would
shift the header. The cover is a fixed height, so nothing placed on it
moves the rest of the header.
ProfileHeaderView gains a coverAccessory slot laid on the cover's bottom
edge: leading at inset + avatar + 12, trailing at the inset, 8 above the
bottom, matching Android. The group profile's mute chip and a person's
Blocked and mute chips move there, leaving the action row to Edit Group
and Share. A timed mute that doesn't fit falls back to "Muted".
Android also adds a 70% background backing under the chip because its
fill is warning at 10% alpha. iOS fills with warningSecondary, which is
opaque, so the backing would draw nothing and is left out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the profile status chips from the action row onto the cover photo, on both the group profile and another person's profile. This matches code-payments/code-android-app#1703 (
fix(groups): put the muted chip on the cover beside the avatarand the follow-up for user profiles).A timed mute ("Muted until 12:15 PM") in the action row leaves too little width for Edit Group and Share; on Android the same layout wrapped Edit Group onto two lines and pushed Share off screen. Putting the chip under the title was ruled out because the mute state arrives after first render and would shift the header. The cover is a fixed height, so nothing placed on it moves the rest of the header.
ProfileHeaderViewgains acoverAccessoryslot on the cover's bottom edge: leading at inset + avatar width + 12, trailing at the inset, 8 above the bottom.ViewThatFits).Android also puts a 70% background backing under the chip, because its fill is the warning colour at 10% alpha and disappears over a photo. iOS fills with
warningSecondary, which is opaque (Color(r: 48, g: 39, b: 29)), so a backing would draw nothing and is left out.