Repository navigation
refactor(chat): remove the card at the head of chat history - #1012
Merged
Merged
Conversation
Match code-android-app#1707: a DM no longer opens with the counterpart's profile card, and a group no longer opens with its own card and Invite People. The nav title still opens the profile, and Share on the group profile still hands out the invite link. Android added a spacer in their place because its long-press menu put the reaction strip under the top bar on the oldest message. iOS lifts the message into its own window clamped to the safe area, so no spacer here. The link card metrics the head card owned move to LinkCardMetrics, and the group card's token lookup goes with it.
…cript-header-card * origin/main: fix(chat): morph Send Cash out of the composer's glass (#1008) fix(profile): open profiles from favorite groups and username search (#1011) fix(photos): set the accent color to blue so picker controls are readable (#1013) feat(profile): link a chat's token from its profile (#1010) # Conflicts: # Flipcash/Core/Navigation/AppRouter+Destination.swift # Flipcash/Core/Screens/Profile/ChatProfileScreen.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches code-payments/code-android-app#1707. A DM no longer opens with the other person's profile card, and a group no longer opens with its own card and Invite People. The encryption marker still heads the transcript.
Both cards repeated what is one tap away: the nav title opens the profile, and Share on the group profile hands out the invite link.
Removed:
ChatItem.profileCardand.groupCard, their models and cells, andContactActionPillonContactAction, the transcript'sonProfileTap,onGroupInvite, and the conversation screen's invite cover and transcript-head stateChatProfileCardCounterpartTests, which covered the DM card's counterpart lookupKept:
headsHistory, which still places the encryption markerShareToChatsSheetand the invite analyticsThe link card metrics the group card owned move to
LinkCardMetricsinLinkGroupCardView.swift, since link cards in messages still use them.One difference from Android: no spacer in the cards' place. Android added one because long-pressing the oldest message put the reaction strip under the top bar. iOS lifts the message into its own window clamped to the safe area, so the strip can't land under the bar.