Repository navigation
fix(chat): merge Send Cash's glass back into the field - #1019
Merged
Merged
Conversation
Typing into an empty draft left the `$` glass where it stood and faded it while the widening field slid over it, so the two edge highlights stacked into a ripple. #1008 joins glass within 8pt, and `$` rests 10pt from the field, so the removed glass had nothing in reach to morph into. The `$` glass now stays mounted. Hidden, it shrinks to 40% and sits in the field's rounded end, so hiding and showing it is a size change the glass container blends rather than an insert and remove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1008. Typing into an empty draft made the
$glass ripple instead of merging into the field.#1008 set the glass container to join shapes within 8pt so no thread shows at rest, but
$rests 10pt from the field. When the draft started, the$glass was removed while it was still out of reach, so.matchedGeometryhad nothing to morph into. It stayed in place and faded while the field widened over it, and the two edge highlights stacked into the ripple. The reverse direction looked right because the bud starts inside the field.$glass now stays mounted whenever$is the control beside the field. Hidden, its slot collapses to zero width and the circle shrinks to 40%, centred in the field's rounded end. Showing and hiding it is now a size change inside the container, which blends it as one shape both ways.The glyph, timings, and the 8pt join distance from #1008 are unchanged. At rest there is still no thread between
$and the field.