Repository navigation
feat(chat): match the edit chrome to the context menu - #715
Merged
Merged
Conversation
An edit raised its blur over the chat screen alone, while the menu that preceded it blurred the whole navigation stack. The transcript sharpened for a frame on the way in and the navigation bar never went soft at all. The held blur now stays over the same host the menu covered and changes only its z-order and its bottom edge: under the navigation bar, so the back button stays legible and tappable, and stopping at the top of the composer, the one piece of chrome an edit needs sharp. The title and avatar fade out for the duration, so the bar reads as empty chrome over the blur, and the back button ends the edit rather than popping the chat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An edit raised its blur over the chat screen alone, while the context menu that preceded it blurred the whole navigation stack. Two things followed from that: the transcript sharpened for a frame on the way into an edit, and the navigation bar never went soft at all.
The held blur now stays over the same host the menu covered, and changes only its z-order and its bottom edge:
Two pieces of chrome follow the same reading. The title and avatar fade out for the duration, leaving the bar reading as empty chrome over the blur — close to how it looks under the menu, which covers them outright. And the back button ends the edit instead of popping the chat, matching the tap-outside gesture that already dismisses it.