Repository navigation
fix(chat): make the whole Send Cash pill tappable while it stands alone - #743
Merged
Merged
Conversation
Alone in the bar, "Send a Tip" (and "Send €" before an ordinary chat exists) spans the width but only answered a tap on its text. The label is the only drawn content and the fill sits on the Button rather than inside the label, so with `.plain` the stretched frame around the text was not a target. The Cancel-edit pill beside it hit the same thing and fixed it the same way: a content shape on the label.
bmc08gt
added a commit
that referenced
this pull request
Sep 11, 2026
…discrete-curve * origin/main: (27 commits) fix(database): share one SQLite writer per owner and take write locks up front (#759) feat(chat): declare the payment action on tip DM payments (#752) refactor(chat): drop the deprecated new_messages overlay (#757) feat(notifications): write prefetched messages into the shared store (#756) refactor(store): move the persistence layer into a shared FlipcashStore package (#755) feat(database): move the SQLite store into the App Group container (#754) feat(database): open the store on demand, close it on background (#753) feat(nse): extension crash reporting, a WAL checkpoint, and on-device push hooks (#751) feat(home): long-press the You tab to open the account switcher (#749) fix(tests): reset Photos access before the previous app instance lingers (#746) chore: bump version to 2026.9.2 (#745) revert: back out the Coinbase Stable Swapper authority migration (#747) (#750) fix(swap): follow the Coinbase Stable Swapper authority migration (#747) fix(tests): cancel a cash link through the details screen (#744) fix(chat): make the whole Send Cash pill tappable while it stands alone (#743) fix(username): drop a leading @ in the validator (#742) fix(chat): scope the send-button spring to the button (#741) fix(transactions): tighten the details card stack and drop the header badge (#740) fix(transactions): draw View in Chat as a card, not the primary action (#739) feat(chat): flash the message a reply-quote jump lands on (#738) ... # Conflicts: # Code.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # FlipcashCore/Package.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a tip DM opened from the username lookup, the full-width "Send a Tip" button only opened the amount screen when the tap landed on its text. The same held for the full-width "Send €" before an ordinary chat exists.
SendCashMorphButtonuses.buttonStyle(.plain), which hit-tests only what the label draws. The label is the text alone: the white fill and the glass are applied to the Button from outside, because they have to fade during the morph rather than swap views. So the stretched frame around the text was never a target. Once a chat exists the button shrinks to text plus padding, which is why the minimized square never showed it.The fix is a
contentShapeon the label, the same thingCancelEditButtonin the same file already does for the same symptom.The shared button styles (filled, card, icon, subtle, keypad,
CodeButton) all draw their fill inside the styled label or set a content shape, so nothing built on them has this gap. The one other plain-style site with the same shape isChartRangePicker's unselected segments, which is left for a separate change.