Repository navigation
fix(chat): show the external link warning as an info dialog - #954
Merged
Merged
Conversation
Retitle it "You're Leaving Flipcash" and change the body to "This will open <host>. Never share your Access Key with a website". The dialog moves from the red alert style to info, with Open Website as the primary button and Cancel as the secondary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning before a non-Flipcash link from chat opens is now an info dialog instead of a red alert.
.standard("Open Website")then.cancel(), the same pattern as the "No Balance Yet" dialog.The dialog fires on every external link tap, and the app has no idea whether a given link is malicious. A red alert every time would teach people to tap past it, so the Access Key reminder is shown as information.
ExternalLinkCheckTests.warningNamesTheHostnow checks the new copy and button order, and also checks that the style is.standard, so the dialog can't go back to red without the test failing.Android counterpart: code-payments/code-android-app#1673