Fix monolog compatibility, add CI compatibility matrix and fix PHPStan errors - #92
Merged
Merged
Conversation
AUDUL
commented
Oct 2, 2026
AUDUL
commented
Contributor
- Use a stream resource in JobProcessor instead of the fileOpenMode named argument (monolog >= 3.8 only)
- Require monolog ^3.0 (monolog-bridge 7.4 does not allow ^2)
- Frequency constraint: use PHP attribute
- CI: PHP 8.2-8.5 x highest/lowest, dbal 3 and 4, php-cs-fixer, PHPStan
- Fix PHPStan errors (always-true instanceof, DateTimeInterface clone, int/string in ExpressionBuilder::in())
…n errors - Use a stream resource in JobProcessor instead of the fileOpenMode named argument (monolog >= 3.8 only) - Require monolog ^3.0 (monolog-bridge 7.4 does not allow ^2) - Frequency constraint: use PHP attribute - CI: PHP 8.2-8.5 x highest/lowest, dbal 3 and 4, php-cs-fixer, PHPStan - Fix PHPStan errors (always-true instanceof, DateTimeInterface clone, int/string in ExpressionBuilder::in())
- Add Rector job (PHP 8.4) and apply its suggestions - Add league/flysystem to require-dev so PHPStan knows its classes - Run code style and PHPStan on PHP 8.4 (DateInterval::createFromDateString only throws since PHP 8.3, making the catch a dead catch on 8.2)
jeremycr
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.