Repository navigation
Conversation
Chunked review merged a contradictory report when chunks returned issues with an empty summary field: the header counted the issues but the fallback summary printed 'No issues found across all chunks.' (live: gaira PR #108 run #1388 verdict comment). The fallback keyed only off summaries/any_error and never consulted the collected issues. Extract the decision into merged_chunk_summary() with an explicit issue-count branch (issue_count > 0 and any_error now compose into one honest message), unit-test all five outcomes. Gating is unchanged: exit code still derives from should_block. Fixes #556
ajianaz
force-pushed
the
fix/556-chunked-summary-footer
branch
from
October 4, 2026 09:06
629eec4 to
fe1169c
Compare
Collaborator
Author
|
Auto-closed mechanically: this PR's temporary base (chore/560-rustls-02345) was deleted when #561 merged with --delete-branch, and GitHub cannot reopen a PR whose base ref is gone. Replaced by the identical rebased commit as a new PR (base develop). Same content, already CI-proven green 14/14. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Chunked review mode can emit a contradictory report — header
Found 1 issue ... ⚠ BLOCKEDwith footerNo issues found across all chunks.— when chunks return issues with an emptysummaryfield. Extract the merged-summary decision intomerged_chunk_summary()with an explicit issue-count branch, and unit-test all five outcomes.Why
The old fallback keyed only off
summaries/any_errorand never consulted the collected issues (live: gaira PR #108 run #1388 verdict comment, 2026-10-04). Human readers use the verdict text to judge merges, so it must not contradict the issue count. Gating is unchanged: exit code still derives fromshould_block. Details in #556.Testing
cargo test --bin cora commands::review→ 13 passed, 0 failed (5 new tests, incl. the live regression case)cargo fmt --all -- --check→ cleancargo clippy --all-targets -- -D warnings→ clean modulo Clippy fails on rustc 1.99: deprecated std::f32::EPSILON in vector.rs tests blocks all local commits #557 (pre-existing, toolchain-skew errors insrc/index/vector.rs, unrelated file; fixed separately in fix(index): drop deprecated std::f32 import in vector tests #558)