fix(ci): CLA check skips bot PRs with exact allowlist - #12
Merged
Merged
Conversation
Same fix as uteke#1148 / vecq#14: dependabot PRs report their login as 'dependabot[bot]' in github.event.pull_request.user.login (REST form), so bot PRs (e.g. #10) failed cla-check. This workflow version had no bot allowlist at all — add the job-level skip with exact bot logins plus legacy app/ forms as fallback.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (description of the issues)
What (description of the change)
Add a job-level
if:skip for bot PRs to the cla-check job:dependabot[bot],renovate[bot],github-actions[bot](legacyapp/forms kept as fallback). This workflow version had no bot allowlist at all.Why (reasoning and context)
Same bug family as uteke#1148. Live proof in this repo: open dependabot PR #10 (
bump actions/github-script from 7 to 8) shows cla-check FAILURE — the synchronize event will now skip cla-check entirely.Testing (how the change was tested)
if:condition present with exact dependabot[bot] login)