Skip to content

feat: filter columns from their headers - #20

Merged
SyedSibtainRazvi merged 5 commits into
mainfrom
feat/column-filters
Nov 16, 2026
Merged

SyedSibtainRazvi merged 5 commits into
mainfrom
feat/column-filters

Conversation

@SyedSibtainRazvi

@SyedSibtainRazvi SyedSibtainRazvi commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Etiquettes of raising a PR

PR reviews are a way to request peers to give feedback on the code that is going
to the mainline. This means, that PR should be in a reviewable state. Please ensure
that the following checkboxes are ticked. If any of them are not ticked, then
the PR is not ready for review

  • Did you test changes locally?
  • Did you check PR contents after opening the PR

Related issue

Functionalities added or changed

  • Filters in the header: a column with filterFn: textFilter or filterFn: valuesFilter gets a funnel button. It opens a panel with a "contains" input, or a checklist of the column's values with their counts. Columns without one are unchanged.
  • No matches: when the filters hide every row, the sheet says so, with a "Clear filters" button.
  • useSheet turns on TanStack's faceting, which the checklist reads. It only counts when a checklist opens.
  • Playground: the 1,000-row demo filters Title by text, and Status and Owner by value.
  • Docs: the README (filters, labels, API reference), architecture and decisions.

Additional info

  • Nothing breaking. New labels: filter, filterText, blank, clearFilter, noMatches and clearFilters.
  • The panel is the browser's own popover, placed with CSS anchor positioning, which every major browser has supported since January 2026. So there's no new dependency and no positioning code.
  • No search box across all columns yet, by choice. TanStack's setGlobalFilter already works with an app's own input.
  • Tests: 13 new unit tests (137 in total) and 8 new e2e tests (33), including an axe scan with a filter open.

Checklist

  • Tests
  • Translations
  • Documentation
  • Uploaded screenshots
  • Verified on preview url once

Screenshots

Page(s) if applicable

A status checklist and a text filter, in light and dark mode and right to left, and the state when nothing matches:

Device Design Implementation
Mobile — —
Desktop — The Status filter: a checklist of statuses with their counts
The Title filter: a text input
The Owner filter in dark mode
The Status filter, right to left
No rows match the filters, with a Clear filters button

@SyedSibtainRazvi SyedSibtainRazvi self-assigned this Nov 12, 2026
@SyedSibtainRazvi
SyedSibtainRazvi merged commit 3c4527e into main Nov 16, 2026
1 check passed
@SyedSibtainRazvi
SyedSibtainRazvi deleted the feat/column-filters branch November 16, 2026 10:00
This was referenced Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant