Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
name: Release

# Publishes @codemancers/sheets to npm when a GitHub release is published.
# npm trusts this workflow (trusted publishing), so there's no npm token.
# npm trusts this workflow (trusted publishing), so there's no npm token. The
# trusted publisher on npmjs.com must allow `npm publish`: npm sets new ones to
# allow only `npm stage publish`, and `npm publish` then fails with E403.
on:
release:
types: [published]
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,4 @@ Maintainers release from `main`:

1. In a pull request, bump `version` in `packages/sheets/package.json`. Until 1.0, a breaking change bumps the minor version, and anything else bumps the patch version.
2. Once it's merged, publish a GitHub release for that version: `gh release create v0.2.0 --generate-notes`.
3. The [Release workflow](.github/workflows/release.yml) checks that the tag matches the version, then tests, builds and publishes the package to npm. npm trusts that workflow through [trusted publishing](https://docs.npmjs.com/trusted-publishers), so there's no npm token to store or rotate.
3. The [Release workflow](.github/workflows/release.yml) checks that the tag matches the version, then tests, builds and publishes the package to npm. npm trusts that workflow through [trusted publishing](https://docs.npmjs.com/trusted-publishers), so there's no npm token to store or rotate. The trusted publisher, in the package's settings on npmjs.com, must allow `npm publish` under Allowed actions. npm sets new ones to allow only `npm stage publish`, and the publish then fails with `E403 OIDC permission denied`.
2 changes: 1 addition & 1 deletion packages/sheets/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@codemancers/sheets",
"version": "0.2.0",
"version": "0.2.1",
"description": "Spreadsheet-style data grid for React: headless hooks on TanStack Table, plus Tailwind v4 components.",
"license": "MIT",
"repository": {
Expand Down
Loading