Skip to content

feat: type straight into cells, and add rows from right below them - #23

Merged
SyedSibtainRazvi merged 3 commits into
mainfrom
feat/data-entry
Nov 19, 2026
Merged

SyedSibtainRazvi merged 3 commits into
mainfrom
feat/data-entry

Conversation

@SyedSibtainRazvi

@SyedSibtainRazvi SyedSibtainRazvi commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Etiquettes of raising a PR

PR reviews are a way to request peers to give feedback on the code that is going
to the mainline. This means, that PR should be in a reviewable state. Please ensure
that the following checkboxes are ticked. If any of them are not ticked, then
the PR is not ready for review

  • Did you test changes locally?
  • Did you check PR contents after opening the PR

Related issue

Functionalities added or changed

  • "+" right below the rows: the add-row button follows the last row instead of being pinned to the bottom of the sheet. It sits in the row-number column, where the next row's number would be, and the top border it needed as a pinned footer is gone. On a long list, you scroll to the end to reach it.
  • Typing into a cell: in the built-in editable cells (SheetEditableTextCell, and SheetPrimaryCell with editable), typing a character on a focused cell opens the editor with that character, replacing the value, as in a spreadsheet. Tab already moves on to the next cell, so you can type, press Tab and type again. F2 opens the editor with the value kept, as Enter and Space do. Ctrl and Cmd shortcuts are left alone, and AltGr characters such as @ work.
  • useInlineEdit: beginEdit(draft?) opens the editor on draft instead of the value. The editor puts the caret after the text, except in inputs that have no caret, such as number inputs.
  • Docs: the README (keyboard, layout, API reference), architecture, decisions, and CONTRIBUTING's cell guide.

Additional info

  • No API breaks. Apps will see two visible changes: where the "+" sits, and that typing on a focused cell now edits it. One stray key followed by a click away saves a one-character value, because blur saves; Escape undoes it. decisions.md records this.
  • In Gather, the name cell's hover icons and the row actions are still extra Tab stops between cells.
  • Tests: 9 new unit tests (147 in total) and 2 new e2e tests (35): typing a whole row and saving it, and the position of the "+". The axe scan has no violations.

Checklist

  • Tests
  • Translations
  • Documentation
  • Uploaded screenshots
  • Verified on preview url once

Screenshots

Page(s) if applicable

The add-row demo, before and after:

Device Design Implementation
Mobile — —
Desktop Before: the + is pinned to the bottom of the sheet After: the + sits under the row numbers, right below the last row

@SyedSibtainRazvi
SyedSibtainRazvi merged commit 450c9fb into main Nov 19, 2026
1 check passed
@SyedSibtainRazvi
SyedSibtainRazvi deleted the feat/data-entry branch November 19, 2026 04:24
This was referenced Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant