Repository navigation
chore(coderd_template): drop workarounds for Coder versions before v2.15.0 - #450
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c61b2b16d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review re: Document the new Coder v2.15 minimum Leaving this one out on purpose. v2.15.0 is from September 2024, and #449 already dropped the provider-wide minimum version note for the same reason (floors that old aren't useful). Resource-level version notes are reserved for versions people are realistically still running. The failure here is also loud: the apply errors rather than drifting. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
coderd_templatestill had workarounds for Coder versions before v2.15.0, which couldn't setmax_port_share_levelwhen creating a template. After every create we sent a second PATCH just to set it, and at the end of every create and update we fetched the template again to get the real values.v2.15.0 came out over two years ago, so this removes both. We now send
max_port_share_levelin the create request, and read the update result straight from the PATCH response. The template resource now needs Coder v2.15.0 or later.One gotcha: without the port sharing control entitlement (i.e. AGPL), Coder rejects any
max_port_share_levelon create, evenpublic, which is the only level it allows there. So we just leave it out in that case.The extra PATCH for
use_classic_parameter_flowstays, as Coder only accepts it on create from v2.25.0.