Skip to content

feat!: remove redundant id from coderd_agents_default_model and coderd_ai_model_price - #452

Merged
ethanndickson merged 1 commit into
mainfrom
agents-model-r3y5
Oct 8, 2026
Merged

ethanndickson merged 1 commit into
mainfrom
agents-model-r3y5

Conversation

@ethanndickson

Copy link
Copy Markdown
Member

Both of these resources had a computed id that just repeated other attributes. On coderd_agents_default_model it was the organization ID, so plans showed the same UUID as organization_id, and on coderd_ai_model_price it was <provider_type>/<model>. Neither resource creates an object of its own in Coder, so there's no real ID to expose.

Breaking change for changelog:

coderd_agents_default_model and coderd_ai_model_price no longer have an id attribute. Use organization_id on coderd_agents_default_model, and provider_type and model on coderd_ai_model_price.

Existing state doesn't need migrating, as the framework drops the old id key when it reads state, and import IDs are unchanged. Both resources are experimental, so I think the break is fine.

I've also fixed the stale coderd_default_agents_model name in AGENTS.md.

@ethanndickson

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T06:51:08.853789Z e6ee437 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: e6ee437230

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ethanndickson
ethanndickson marked this pull request as ready for review October 6, 2026 06:48
@ethanndickson
ethanndickson requested a review from matifali October 6, 2026 12:21

@matifali matifali left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it looks good. Don't have context on why it was added and why it is not used.

@ethanndickson

Copy link
Copy Markdown
Member Author

Approving as it looks good. Don't have context on why it was added and why it is not used.

We needed it before we had organization_id, so you could import, and then I forgot to get rid of it when I added organization_id.

@ethanndickson
ethanndickson merged commit 21d42d7 into main Oct 8, 2026
14 checks passed
@ethanndickson
ethanndickson deleted the agents-model-r3y5 branch October 8, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants