Repository navigation
feat!: remove redundant id from coderd_agents_default_model and coderd_ai_model_price - #452
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
We needed it before we had |
Both of these resources had a computed
idthat just repeated other attributes. Oncoderd_agents_default_modelit was the organization ID, so plans showed the same UUID asorganization_id, and oncoderd_ai_model_priceit was<provider_type>/<model>. Neither resource creates an object of its own in Coder, so there's no real ID to expose.Breaking change for changelog:
Existing state doesn't need migrating, as the framework drops the old
idkey when it reads state, and import IDs are unchanged. Both resources are experimental, so I think the break is fine.I've also fixed the stale
coderd_default_agents_modelname inAGENTS.md.