Repository navigation
🤖 tests: characterize session usage repricing in WorkspaceStore - #6306
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds characterization tests for how
WorkspaceStorereprices loaded session usage. They pin which rows keep their recorded costs (gateway-billed rows) and which rows get the current model pricing. Test-only change, no production code changes.Background
This PR is part of the CRAP code-quality campaign.
isCostsIncludedEntryinsrc/browser/stores/WorkspaceStore.tshad CC 18 and no test reached it (CRAP 342, the highest score in the file). With these tests, merged CI coverage plus a local run scores it at 100% coverage, CRAP 18.Implementation
The tests go through the public store surface: a
getSessionUsageresponse, the provider config (providers.getConfig,onConfigChanged), andgetWorkspaceUsage().sessionByModel/.lastRequest. They cover:costsIncluded: truekeeps zero costs, and it wins overhasUnknownCosts;hasUnknownCosts: truerows get priced;Each workspace gets a caught-up chat first. Before catch-up,
getWorkspaceUsageserves the pre-replay snapshot, which would hide the repriced rows.Validation
isCostsIncludedEntryand itsrepriceSessionUsagecall sites (drop each check, swap the marker order, use the raw model for pricing, check only the input cost, never sethasTokens, ignore the marker forlastRequest): every mutant fails at least one new test.Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high