Repository navigation
🤖 tests: characterize consumer breakdown cache hydration in WorkspaceStore - #6308
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds characterization tests for the Costs tab consumer breakdown in
WorkspaceStore: when the store shows the token-stats cache persisted insession-usage.json, and when it recounts instead. Test-only change, no production code changes.Background
This PR is part of the CRAP code-quality campaign. No test called
getWorkspaceConsumers(CC 8, CRAP 72) orgetMaxHistorySequence(CC 6, CRAP 42) insrc/browser/stores/WorkspaceStore.ts. With these tests, merged CI coverage plus a local run scores both at 100% coverage (CRAP 8 and 6).Implementation
Each test loads a session usage with a
tokenStatsCache, then replays a two-message history (sequences 3 and 7) and readsgetWorkspaceConsumers. The chat script holds the replay until the session usage is in memory, so catch-up sees the cache. The tests cover:maxHistorySequencefalls back to the message count;getWorkspaceConsumersread schedules the recount.Validation
getWorkspaceConsumersremoved): each fails at least one new test.caughtUpcondition ingetWorkspaceConsumers. Before catch-up the aggregator holds no messages in these flows, so the condition changes nothing a test can see here. I did not add a test for it.Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high