Repository navigation
Conversation
Convert version 1 .decls and .dtrace test inputs to version 2, and remove version 1 test inputs that are not worth converting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (15)
📒 Files selected for processing (48)
💤 Files with no reviewable changes (22)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change converts several declaration fixtures to version 2.0, removes other declaration and specification fixtures, and updates splitters to track array variables alongside indices or sizes. It also removes the StackAr diff-test fixtures and changes the diff-test directory list to include StackAr. Priority: ⬇️ Low Change: Other Merge Risk: ⚪ Minimal · up to This change updates test input files to the newer declaration format and removes obsolete test inputs. It does not change production behavior, and the author reports that the affected tests pass. No merge-blocking risk was found. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 3 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #880.
Converts the version 1
.declsand.dtracetest inputs (split targets,dtracediff,SampleTester.decls, and thepine_mdiep,schedule,schedule2, andtcassystem tests) to version 2. Removes version 1 test inputs that are not worth converting:RatNum,StackAr, andfuzzysplit targets,SampleTesterGlobal.decls, theStackArdiff-test, and the Kvasirdisambiggoal files.Daikon already reads version 2, so this does not depend on dropping version 1 support.
Testing, with master's code:
make -C java junitpasses,SplitterFactoryTestpasses, and thepine_mdiep,schedule,schedule2,tcasdaikon-tests and theschedule2diff-test pass.🤖 Generated with Claude Code