Define DAIKONDIR in the test driver Makefiles

[mernst]

tests/Makefile, tests/kvasir-tests/Makefile, and tests/dyncomp-tests/Makefile use ${DAIKONDIR} (via PLUME_SCRIPTS) without defining it. Without DAIKONDIR in the environment, PLUME_SCRIPTS became /.utils/plume-scripts, so for example is-ci.sh failed and make regression-tests in kvasir-tests took the non-CI branch. This also fixes make summary (and other targets that recurse with make -C ..) in tests/daikon-tests.

Companion to #898.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: codespecs/daikon/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 8bc98a43-b4d7-4e65-b642-f1aac9482698

---

📥 Commits

Reviewing files that changed from the base of the PR and between 779e30d and 3c09a11.

---

📒 Files selected for processing (3)

• tests/Makefile
• tests/dyncomp-tests/Makefile
• tests/kvasir-tests/Makefile

---

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

---

📝 Walkthrough

📝 Walkthrough

📝 Walkthrough

Walkthrough

Three test Makefiles now define variables for their Makefile directories. Each sets DAIKONDIR to a path derived from that directory only when DAIKONDIR is unset.

---

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 3c09a

No concrete merge-blocking risk was identified in the changed test-directory defaults.

Architecture Summary

Architecture risk: 🔵 Low · up to 3c09a

The change affects 1 system.

Changed systems: tests

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — tests (service) was modified; 3 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in tests/Makefile: Adds TESTS_MAKEFILE_DIR, immediately expanded from the last entry in MAKEFILE_LIST, and a default for DAIKONDIR based on its parent directory; an existing DAIKONDIR value is preserved.
• observed — Modified behavior in tests/dyncomp-tests/Makefile: Adds comments and initializes DYNCOMP_DRIVER_DIR from the current Makefile path using :=; when DAIKONDIR is unset, assigns it the real path two directories above DYNCOMP_DRIVER_DIR.
• observed — Modified behavior in tests/kvasir-tests/Makefile: The Makefile adds comments and defines KVASIR_DRIVER_DIR from the last entry in MAKEFILE_LIST; DAIKONDIR now defaults to the real path of the directory two levels above that driver directory.

---

Pre-merge checks | 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

---

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

---

🧪 Generate unit tests (beta)

• Create a new PR

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

[mernst]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[mernst]

Superseded by tests/Makefile.jobs on master.