Repository navigation
Backport upstream Valgrind fix for $(nproc) in auxprogs/Makefile.am - #84
Merged
Merged
Conversation
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25. Or wait 54 minutes for your next included review. View limit details
Comment |
mernst
changed the title
$ in shell command substitution in a Makefile recipe$(nproc) in auxprogs/Makefile.am
markro49
approved these changes
Oct 12, 2026
mernst
added a commit
to mernst/fjalar
that referenced
this pull request
Oct 17, 2026
mernst
added a commit
to mernst/fjalar
that referenced
this pull request
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
valgrind/auxprogs/Makefile.am, make expanded$(nproc)as an undefined make variable, so the command wasmake -jwith unlimited parallelism.This backports the fix from upstream Valgrind commit ccf065e7 ("Run the LTP tests with LTP_QUIET"), which removes
-j $(nproc)from the GSL build. Matching upstream exactly means that this difference disappears at the next Valgrind merge.