Repository navigation
CHANGELOG: log the MLPE change, which is breaking - #15
Merged
Merged
Conversation
#14 removes the estimator from MLPE: MLPE(LogisticRegression()) now raises TypeError, cv, stratified and shuffle are gone from the signature, and there is no estimator_ after fit. Anyone upgrading without reading the diff finds that at runtime, so it belongs in the file -- under Breaking Changes, which is the section the v0.5.0 entry already uses for exactly this kind of change, and which Unreleased did not have. The entry says plainly that the estimate does not change and that migration is to drop the argument, because the breakage is in the signature and not in the numbers. #13 is not logged: it changed this file's own labels and links, which is not a user-visible change to the library. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14 removes the estimator from
MLPE.MLPE(LogisticRegression())now raisesTypeError,cv/stratified/shuffleare gone from the signature, and there is noestimator_afterfit.Anyone upgrading without reading the diff finds that at runtime. The
Unreleasedsection had no### Breaking Changesheading at all, although the v0.5.0 entry already uses that section for exactly this kind of change — the evaluation-metrics argument reorder.The entry
It leads with what breaks and how to migrate (drop the argument —
MLPE()), and says plainly that the estimate does not change: it was always the training prevalence read from the labels. The breakage is in the signature, not in the numbers.Then why, with the measurement that justified it:
And the comparison that identified the cost:
CC, which trains one classifier and nothing else, cost 0.0523 s againstMLPE's 0.0571 s over 142 datasets. What remained was oneLogisticRegression.fit, for work the estimate never used.fitnow takes 0.55 ms instead of ~57 ms, and the whole method over 142 datasets takes 50 s of CPU against 40 min.Every figure was checked against
q2_custo.csvof the two runs before being written.Not logged
#13 changed this file's own section label and compare links. That is not a user-visible change to the library, and a changelog logging edits to itself would be noise.
Markdown only.
🤖 Generated with Claude Code