Repository navigation
feat(agentconfig): change-safety classification and wire types (3/15) - #471
Merged
gusfcarvalho merged 3 commits intoOct 6, 2026
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 5, 2026
gusfcarvalho
approved these changes
Oct 5, 2026
This was referenced Oct 6, 2026
Third layer of the agent remote-configuration stack (split from #465): Classify/WillApply decide which overlay changes an agent applies under each remote_config mode (forbidden locked keys, unsafe new sources and re-enabled plugins, sources of enabled plugins already in use, trusted sources, overridable flags), plus the agent<->API wire types and FieldError. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…erences
Re-enabling a disabled plugin only checked its source, so its policy
entries and ${env:} references, which no enabled plugin uses, were
never classified and apply_safe could run an untrusted or local policy
the host had disabled. They are now classified like a new plugin's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…new one Re-enabling a plugin the base disables only checked trusted_sources, so a local-path source was just unsafe/reenables-plugin and apply_all applied it even with allow_local_sources=false. Run the kept local source through the source rules too: forbidden/local-source-not-allowed unless apply_all with allow_local_sources (then unsafe/new-local-source). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ccf-lisa
Bot
force-pushed
the
lisa/agent-config/03-classify
branch
from
October 6, 2026 13:06
26bfc21 to
4a5babf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3/15 of the agent remote-configuration stack
This stack splits #465 into reviewable layers of at most ~1000 changed lines each (counted without
docs/,go.sumand Markdown). The last layer's tree is identical to #465, which already has its review history.Stacked on #470 (
lisa/agent-config/02-diff-envrefs-sources). Review and merge in order.What's in this layer
Third layer of the agent remote-configuration stack (split from #465): Classify/WillApply decide which overlay changes an agent applies under each remote_config mode (forbidden locked keys, unsafe new sources and re-enabled plugins, sources of enabled plugins already in use, trusted sources, overridable flags), plus the agent<->API wire types and FieldError.
Size: +1055 -0 = 1055 changed lines (without docs/go.sum).
Verification
Each layer builds on its own:
go build,go vet(also with-tags integration),golangci-lint runandgo test ./...pass, andmake swagleaves the tree clean. Integration suites for the packages this layer touches pass locally on testcontainers Postgres.🤖 Generated with Claude Code