Skip to content

Do not show props et al if they have no values to show #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ianmiell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not show props et al if they have no values to show #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/views/control-implementations/partials/ControlStatementMetadata.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@ const emit = defineEmits<{

function formatProps(props: Statement['props']): string {
if (!props?.length) {
return 'None';
return '';
}

return props
.map((prop) => {
if (prop.name && prop.value) {
Expand All @@ -28,9 +27,8 @@ function formatProps(props: Statement['props']): string {

function formatLinks(links: Statement['links']): string {
if (!links?.length) {
return 'None';
return '';
}

return links
.map((link) => link.text || link.href || link.rel || 'Link')
.join(', ');
Expand All @@ -47,23 +45,23 @@ function formatLinks(links: Statement['links']): string {
/>
<p class="text-sm">{{ statement.statementId }}</p>
</div>
<div>
<div v-if="statement.remarks">
<TooltipTitle
text="Remarks"
tooltip-key="statement.remarks"
underline-class="text-sm font-medium text-gray-500 underline decoration-dotted cursor-help"
/>
<p class="text-sm">{{ statement.remarks || 'None' }}</p>
<p class="text-sm">{{ statement.remarks }}</p>
</div>
<div>
<div v-if="statement.props">
<TooltipTitle
text="Props"
tooltip-key="statement.props"
underline-class="text-sm font-medium text-gray-500 underline decoration-dotted cursor-help"
/>
<p class="text-sm">{{ formatProps(statement.props) }}</p>
</div>
<div>
<div v-if="statement.links">
<TooltipTitle
text="Links"
tooltip-key="statement.links"
Expand Down
Loading