Skip to content

feat(agent-config): configuration history and revert [19/21] - #340

Merged
gusfcarvalho merged 1 commit into
agent-config/18-plugin-tabsfrom
agent-config/19-history
Oct 6, 2026
Merged

gusfcarvalho merged 1 commit into
agent-config/18-plugin-tabsfrom
agent-config/19-history

Conversation

@gusfcarvalho

Copy link
Copy Markdown
Contributor

Part 19 of 21 of the stacked split of #318 (agent remote configuration). Every layer adds the final version of its files from #318, and only imports from layers below it, so each layer passes make reviewable on its own. Nothing is reachable in the app until layer 20 wires the Configuration tab in.

What

Configuration history: list of past overlay versions, YAML/merge diff between versions and revert.

Tests

AgentConfigHistory.spec.ts.

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings October 5, 2026 10:52
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7d530e06-180d-4730-9eec-fc9846c513d0
📥 Commits

Reviewing files that changed from the base of the PR and between c5da8fa and 8d58a72.

📒 Files selected for processing (2)
  • src/components/agents/config/AgentConfigHistory.vue
  • src/components/agents/config/__tests__/AgentConfigHistory.spec.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Revert submission must re-check eligibility when confirmation is already open.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Adds configuration history for agent overlays, ready for Configuration-tab integration in layer 20.

Changes:

  • Lists revisions with pagination and YAML viewing/comparison.
  • Supports reverting with comments and API error handling.
  • Adds tests for history, revert outcomes, and overlapping requests.
File Description
src/​components/​agents/​config/​AgentConfigHistory.vue Implements history, comparisons, and revert dialogs.
src/​components/​agents/​config/​__tests__/​AgentConfigHistory.spec.ts Tests history loading, actions, errors, and request ordering.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +432 to +433
async function doRevert() {
reverting.value = true;
@gusfcarvalho
gusfcarvalho force-pushed the agent-config/19-history branch from f05c62d to b22cb23 Compare October 5, 2026 16:32
@ccf-lisa
ccf-lisa Bot force-pushed the agent-config/19-history branch from b22cb23 to 6f3fd1c Compare October 6, 2026 09:40
@ccf-lisa
ccf-lisa Bot force-pushed the agent-config/19-history branch from 6f3fd1c to b0045b8 Compare October 6, 2026 11:38
@ccf-lisa
ccf-lisa Bot force-pushed the agent-config/19-history branch from b0045b8 to 437852f Compare October 6, 2026 11:51
ianmiell
ianmiell previously approved these changes Oct 6, 2026

@ianmiell ianmiell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ccf-review: APPROVE

no findings.

Stack (gh stack 343): #322 → #323 → #324 → #325 → #326 → #327 → #328 → #329 → #330 → #331 → #332 → #333 → #334 → #335 → #336 → #337 → #338 → #339 → #340 → #341 → #342

@ccf-lisa
ccf-lisa Bot force-pushed the agent-config/19-history branch from 437852f to 829bf5c Compare October 6, 2026 13:32
@ccf-lisa
ccf-lisa Bot force-pushed the agent-config/19-history branch 2 times, most recently from 95b49ff to 6a0b1bc Compare October 6, 2026 14:38
Layer 19 of 21 in the stacked split of #318.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gusfcarvalho
gusfcarvalho force-pushed the agent-config/19-history branch from 6a0b1bc to 8d58a72 Compare October 6, 2026 15:14
@gusfcarvalho
gusfcarvalho merged commit 09d7f7c into main Oct 6, 2026
4 checks passed
@gusfcarvalho
gusfcarvalho deleted the agent-config/19-history branch October 6, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants