Repository navigation
Conversation
Replaced unsafe `execSync` with `spawnSync` when running the syntax checker in `packages/core/src/reconcile.ts`. Using `execSync` with a string interpolated path is vulnerable to command injection if the workspace path contains shell metacharacters. By using `spawnSync(process.execPath, ['--check', tempFile])` instead, the file path is safely passed directly as an argument, bypassing the shell. Also replaced the hardcoded `node` command with `process.execPath` to ensure the correct Node.js binary is used safely. Co-authored-by: connerkup <72580335+connerkup@users.noreply.github.com>
Deploying shielded-shell with
|
| Latest commit: |
480f11b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d07e3746.shielded-shell.pages.dev |
| Branch Preview URL: | https://sentinel-fix-command-injecti.shielded-shell.pages.dev |
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🚨 Severity: CRITICAL
💡 Vulnerability: Command Injection in
packages/core/src/reconcile.ts.🎯 Impact: An attacker or malicious AI could potentially inject shell commands if the workspace folder or generated
tempFilepath contained quotes or shell metacharacters, leading to arbitrary code execution outside the validation sandbox.🔧 Fix: Replaced
execSyncwithspawnSync, which accepts arguments as an array avoiding shell interpolation. Additionally usedprocess.execPathinstead of relying on the systemnodeexecutable from$PATH.✅ Verification: Verified by running
npm run lintandnpm run test -w @shieldedshell/core. All checks passed.PR created automatically by Jules for task 16034848206084478146 started by @connerkup