Repository navigation
Conversation
Replaced `execSync` with `spawnSync` in `packages/core/src/reconcile.ts` to prevent command injection vulnerabilities. `execSync` evaluated a dynamically constructed command containing file paths that could have shell metacharacters. `spawnSync` provides a safer execution using argument arrays. Error handling was adapted to handle `spawnSync` output properly. Co-authored-by: connerkup <72580335+connerkup@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying shielded-shell with
|
| Latest commit: |
6e0c637
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b15b0214.shielded-shell.pages.dev |
| Branch Preview URL: | https://fix-command-injection-reconc.shielded-shell.pages.dev |
🚨 Severity: CRITICAL
💡 Vulnerability: Command injection vulnerability via
execSyncwith dynamically constructed strings.🎯 Impact: An attacker could execute arbitrary shell commands if they control the file path.
🔧 Fix: Replaced
execSyncwithspawnSync, passing arguments as an array instead of a formatted string, and properly handling exit codes.✅ Verification: Ran
npm run test -w @shieldedshell/coreand verified all tests still pass.PR created automatically by Jules for task 17444157610258850632 started by @connerkup