Skip to content

🛡️ Sentinel: [HIGH] Fix command injection risk in reconcile.ts #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connerkup wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🛡️ Sentinel: [HIGH] Fix command injection risk in reconcile.ts #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## 2023-10-25 - [Command Injection Risk]
**Vulnerability:** Use of `execSync` with a string interpolated path in `reconcile.ts` (`execSync(\`node --check "\${tempFile}"\`)`) opened up a command injection risk if the file path was ever attacker-controlled or contained quotes/shell metacharacters.
**Learning:** Even internal file paths (`path.join` with `options.workspace`) shouldn't be blindly trusted to shell execution (`execSync` or `spawn` with `shell: true`), as quotes or shell metacharacters could still technically cause escaping depending on OS path characteristics or upstream workspace configuration.
**Prevention:** Use `spawnSync` (or `spawn`) with an explicit argument array (`["--check", tempFile]`) and avoid shell execution. For Node scripts, invoke `process.execPath` explicitly instead of depending on `node` in the PATH string.
7 changes: 5 additions & 2 deletions packages/core/src/reconcile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { execSync } from "node:child_process";
import { spawnSync } from "node:child_process";
import crypto from "node:crypto";
import fs from "node:fs";
import path from "node:path";
Expand Down Expand Up @@ -139,7 +139,10 @@ export function reconcile(options: ReconcileOptions): ReconcileResult {
fs.writeFileSync(tempFile, extractedCode, "utf8");

try {
execSync(`node --check "${tempFile}"`, { stdio: "pipe" });
const checkResult = spawnSync(process.execPath, ["--check", tempFile], { stdio: "pipe", encoding: "utf8" });
if (checkResult.status !== 0) {
throw new Error(checkResult.stderr || checkResult.stdout || "Syntax check failed");
}
log.audit("Syntax check passed");
} catch (err) {
const stderr =
Expand Down
Loading