Skip to content

🛡️ Sentinel: [CRITICAL] Fix command injection in reconcile syntax check #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connerkup wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🛡️ Sentinel: [CRITICAL] Fix command injection in reconcile syntax check #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## 2024-10-26 - Command Injection via `execSync` Path Formatting
**Vulnerability:** Command injection vulnerability identified in `packages/core/src/reconcile.ts` where a shell string was constructed using `execSync(\`node --check "\${tempFile}"\`, { stdio: "pipe" });`. Since `tempFile` derives from `options.workspace`, any shell metacharacters (e.g. `"; <cmd> ;"`) within the path could lead to arbitrary command execution by the Node.js shell.
**Learning:** `execSync` passes the entire command string to the system shell. When constructing commands that include dynamic or file paths, passing it as a string allows shell injection if the dynamic parts contain unescaped shell operators.
**Prevention:** Avoid `execSync` with template strings containing dynamic paths. Instead, use `execFileSync` (or `spawnSync`) which executes the binary directly without passing the command through a shell. The arguments are passed as an array to `execFileSync`, naturally preventing any shell injections: `execFileSync(process.execPath, ["--check", tempFile], { stdio: "pipe" });`.
4 changes: 2 additions & 2 deletions packages/core/src/reconcile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { execSync } from "node:child_process";
import { execFileSync } from "node:child_process";
import crypto from "node:crypto";
import fs from "node:fs";
import path from "node:path";
Expand Down Expand Up @@ -139,7 +139,7 @@ export function reconcile(options: ReconcileOptions): ReconcileResult {
fs.writeFileSync(tempFile, extractedCode, "utf8");

try {
execSync(`node --check "${tempFile}"`, { stdio: "pipe" });
execFileSync(process.execPath, ["--check", tempFile], { stdio: "pipe" });
log.audit("Syntax check passed");
} catch (err) {
const stderr =
Expand Down
Loading