Skip to content

🛡️ Sentinel: [CRITICAL] Fix command injection in reconcile execution #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connerkup wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🛡️ Sentinel: [CRITICAL] Fix command injection in reconcile execution #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## 2025-02-09 - Avoid execSync for paths controlled by workspace inputs
**Vulnerability:** Command injection vulnerability via `execSync` when executing dynamically generated workspace files. The `tempFile` was generated dynamically in `.shieldedshell/state/temp_check.js` which depended on `options.workspace`, allowing command injection.
**Learning:** `execSync` runs in a shell by default or executes a string as a command, opening the possibility for command injection even for paths that look safe but are controlled by external inputs or environment locations.
**Prevention:** Use `spawnSync` from `node:child_process` with an array-based argument list and `process.execPath` to launch node, removing the shell execution risk.
16 changes: 5 additions & 11 deletions packages/core/src/reconcile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { execSync } from "node:child_process";
import { spawnSync } from "node:child_process";
import crypto from "node:crypto";
import fs from "node:fs";
import path from "node:path";
Expand Down Expand Up @@ -138,20 +138,14 @@ export function reconcile(options: ReconcileOptions): ReconcileResult {
fs.mkdirSync(path.dirname(tempFile), { recursive: true });
fs.writeFileSync(tempFile, extractedCode, "utf8");

try {
execSync(`node --check "${tempFile}"`, { stdio: "pipe" });
log.audit("Syntax check passed");
} catch (err) {
const stderr =
err && typeof err === "object" && "stderr" in err
? String((err as { stderr?: Buffer }).stderr ?? "")
: err instanceof Error
? err.message
: String(err);
const check = spawnSync(process.execPath, ["--check", tempFile], { stdio: "pipe", encoding: "utf8" });
if (check.status !== 0) {
const stderr = check.stderr || (check.error ? check.error.message : "Unknown syntax error");
consolidateSharedContext(sharedContext, `Syntax Error:\n${stderr}`);
if (fs.existsSync(tempFile)) fs.unlinkSync(tempFile);
return { success: false, reason: "Syntax check failed" };
}
log.audit("Syntax check passed");

if (options.benchmark) {
const staticResult = runBenchmarkStaticVerification(options.workspace, options.benchmark);
Expand Down
Loading