Skip to content

🛡️ Sentinel: [HIGH] Fix command injection in Node syntax checker #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connerkup wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🛡️ Sentinel: [HIGH] Fix command injection in Node syntax checker #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## 2024-10-30 - Command Injection in Syntax Checker
**Vulnerability:** Use of string-based \`execSync\` for node syntax checking (\`execSync(\\\`node --check "\${tempFile}"\\\`)\`) allows for potential command injection if \`tempFile\` path can be manipulated.
**Learning:** Even internal tool execution or paths that seem controlled should use array-based argument passing (e.g., \`spawnSync\`) and \`process.execPath\` to absolutely prevent injection vulnerabilities in execution engines.
**Prevention:** Always prefer \`spawnSync\` over \`execSync\`, use \`process.execPath\` for invoking node, and pass arguments as an array rather than constructing a command string.
10 changes: 8 additions & 2 deletions packages/core/src/reconcile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { execSync } from "node:child_process";
import { spawnSync } from "node:child_process";
import crypto from "node:crypto";
import fs from "node:fs";
import path from "node:path";
Expand Down Expand Up @@ -139,7 +139,13 @@ export function reconcile(options: ReconcileOptions): ReconcileResult {
fs.writeFileSync(tempFile, extractedCode, "utf8");

try {
execSync(`node --check "${tempFile}"`, { stdio: "pipe" });
const result = spawnSync(process.execPath, ["--check", tempFile], { stdio: "pipe" });
if (result.error) throw result.error;
if (result.status !== 0) {
const err = new Error("Syntax check failed") as Error & { stderr: Buffer };
err.stderr = result.stderr;
throw err;
}
log.audit("Syntax check passed");
} catch (err) {
const stderr =
Expand Down
Loading