Repository navigation
ci: install ripgrep for scheduled flake detection and release workflows - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosted run: CI 40181786646 — green, 33 min 14 s.
Commit (on
devcd75f16)0f9be063ci: install ripgrep for scheduled flake detection and release workflowsWhat changed
crates/contextdb-cli/tests/read_classification_staged.rsrefuses to run withoutjqandrg, so the command-classification proof can never pass silently.ci.ymlinstalls ripgrep; four workflows that run the full workspace suite did not, so that test failed on every attempt there (#7, and the workspace job of every nightly). This adds the same install step toflake-hunt.yml,release.yml,release-dry-run.ymland the nightlyintegration.ymlslice job, and pins the newintegration.ymlcommand inscripts/ci-integration.py's workflow contract.jqis already onubuntu-latest.Proof
CI_INTEGRATION_DEFAULT=false). With ripgrep present it passes:cargo test --locked -p contextdb-cli --test read_classification_staged→ 1 passed.ci-integration-tests.py(16),ci-inventory-tests.py(14),ci-required-tests.py(11) pass.acceptance,acceptance_syncandsql_surfacewithout test seams (known,.github/CI.md).Cross-family review (Grok)
First pass STEER: the nightly
integration.ymlslice also lacked ripgrep — added, with its contract line. Second pass: no findings.Fixes #7.