Skip to content

[Snyk] Security upgrade shell-quote from 1.8.4 to 1.9.0#12904

Open
sestinj wants to merge 1 commit into
mainfrom
snyk-fix-db519d81c8d9f242d29f14dc6925fda2
Open

[Snyk] Security upgrade shell-quote from 1.8.4 to 1.9.0#12904
sestinj wants to merge 1 commit into
mainfrom
snyk-fix-db519d81c8d9f242d29f14dc6925fda2

Conversation

@sestinj

@sestinj sestinj commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • core/package.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Inefficient Algorithmic Complexity
SNYK-JS-SHELLQUOTE-17457810
  828  

Breaking Change Risk

Merge Risk: Medium

Notice: This assessment is enhanced by AI.


Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@sestinj

sestinj commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Merge Risk: Medium

This minor version upgrade for shell-quote addresses a security vulnerability. While a patch, it introduces stricter validation that could affect specific edge cases.

Key Change:

  • Security Fix: The quote() function no longer allows newline characters within the .op field of object-token inputs. Previously, this could lead to shell command injection. The function will now throw a TypeError for such malformed input.

This is a behavioral change that tightens security by rejecting previously accepted, but unsafe, input. While most applications will be unaffected, any code that incorrectly passes object tokens with newlines to the quote() function will now break.

Source: GitHub Security Advisory

Notice 🤖: This content was augmented using artificial intelligence. AI-generated content may contain errors and should be reviewed for accuracy before use.

@sestinj sestinj requested a review from a team as a code owner June 26, 2026 09:16
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 26, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants