Skip to content

#388 [BRIDGE] QueryAst - Create Query from AskQueryAst#477

Merged
abdessamad-abdoun merged 2 commits into
feature/corese-nextfrom
feature/388-bridge-queryast-create-query-from-askqueryast
Jun 29, 2026
Merged

#388 [BRIDGE] QueryAst - Create Query from AskQueryAst#477
abdessamad-abdoun merged 2 commits into
feature/corese-nextfrom
feature/388-bridge-queryast-create-query-from-askqueryast

Conversation

@abdessamad-abdoun

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown
Overall Project 49.19% 🍏
Files changed 100% 🍏

File Coverage
CoreseAstQueryBuilder.java 68.29% 🍏
Query.java 31.1% 🍏
SparqlAstToExpression.java 21.37% 🍏

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

Test Results

  425 files    425 suites   21s ⏱️
2 405 tests 2 405 ✅ 0 💤 0 ❌
2 419 runs  2 419 ✅ 0 💤 0 ❌

Results for commit 7c2c2e9.

♻️ This comment has been updated with latest results.

@remiceres

Copy link
Copy Markdown
Contributor

I cleaned up the ASK bridge PR to keep it minimal but consistent with the next pipeline. I restored simple clauses already supported by the AST/runtime (FROM, FROM NAMED, LIMIT, OFFSET), kept unsupported semantic features explicitly rejected (ORDER BY, GROUP BY, HAVING, VALUES), fixed Query so ASK is no longer reported as SELECT, and added tests for the expected behavior.

@github-actions

Copy link
Copy Markdown
Overall Project 49.2% 🍏
Files changed 97.25% 🍏

File Coverage
WhereCompiler.java 82.81% 🍏
CoreseAstQueryBuilder.java 74.59% -4.32% 🍏
Query.java 31.21% 🍏
SparqlAstToExpression.java 21.37% 🍏

@abdessamad-abdoun abdessamad-abdoun merged commit b8a41de into feature/corese-next Jun 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants