Fix CRAN-page README rendering and dispatcher arg validation - #57
Merged
Conversation
…raffic
- Close the unclosed fence after the Z-Image example: the whole LTX
section rendered inside a code block on the CRAN page, and the
dispatcher one-liner rendered outside one (now its own block).
- Point cat2.png / gambling_cat.png embeds at raw.githubusercontent
URLs; both files are .Rbuildignore'd, so the relative refs 404 on
the CRAN-rendered README.
- Replace the LTX example with the working call shape (mirrors
R/serve.R): ltx23_load_pipeline() has no checkpoint_path default and
txt2vid_ltx2() needs text_encoder + tokenizer. Also fp8 -> nf4 in
the download comment (nf4 is the default since 0.2.2).
- match.arg() in txt2img() and img2img(): bare txt2img("a cat")
errored with "EXPR must be a length 1 vector", img2img errored on
the length-2 vector condition. Both now default to sd21, with a
tinytest covering the rejection message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Announcement-day polish: fixes for what a new user hits first (the CRAN-rendered README and the bare dispatcher calls).
README (visible on the CRAN page right now)
```rfence opened before the FLUX examples never closed, so the whole LTX section rendered inside a code block and the dispatcher one-liner rendered outside one. Closed it; the dispatcher example is now its own block.cat2.pngandgambling_cat.pngare.Rbuildignored, so the relative image embeds 404 on CRAN. Now absolute GitHub URLs (no tarball bloat).ltx23_load_pipeline()has nocheckpoint_pathdefault, andtxt2vid_ltx2()needstext_encoder+tokenizer(or embeds). Replaced with the working call shape chained offdownload_ltx2()'s return value, mirroringR/serve.R. Also fp8 → nf4 in the download comment (nf4 has been the default since 0.2.2).Dispatchers
txt2img("a cat")errored withEXPR must be a length 1 vector, andimg2img()errored on the length-2 choices vector in anif()condition. Both nowmatch.arg()theirmodel_nameand default to sd21. tinytest covers the rejection message.The
rformat + documentcommit is churn only (7 files rejoined by rformat, man pages rewrapped by tinyrox); the functional diff is the first commit.GitHub's README updates immediately; the CRAN copy follows at the next release.