Repository navigation
feat(analysis): add Cornerstone GHG FBS pin builder toolkit - #1141
Merged
Merged
Conversation
Preflight Energy FBS + NowcastMUT vintages, gas x sector compare, and prepare_pin draft for year-stem pin bumps without changing committed pins.
bl-young
added this pull request to stack #1143
October 22, 2026 18:20
Co-authored-by: Cursor <cursoragent@cursor.com>
catherinebirney
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc:
Related: #1136, #1123
Stack: 1 of 2 (toolkit). Follow-on: promote 2024 regen pin JSON after GCS upload.
What changed? Why?
Adds
bedrock/analysis/ghg_fbs_pin, optional local builder scripts and docs for Cornerstone GHG FBS pin bumps (not a runtime or CI contract).check_upstream_inputsdocuments expected Energy FBS filenames and NowcastMUT vintage and can quarantine rivals;compare_gas_eandprepare_pinhelp rebuild and draft pin JSON/SHA256. Nothing here is wired into model load, pytest, orfbs_regeneration. Does not upload objects or change committed pin/config filenames.Impact
No change to published USA model outputs or
cornerstone_ghg_fbs_filename; analysis-only helper code underbedrock/analysis/with no enforced constraints.Testing
Operator dry-run only (no new automated tests): preflight for 2017-2024 and local year-stem rebuilds; 2024 gas x sector totals matched the transportation NFT golden.
Review focus
upstream_inputs_pin.jsonas operator documentation of what a rebuild used/expects, not a hard pin enforced by the pipeline.Heads-up
GCS upload of Energy/GHG year stems and the repo pin-promote PR are separate follow-ons; merge of this PR alone does not unblock
fbs_regeneration.