Repository navigation
feat(ghg): promote retained-activity Cornerstone 2024 FBS pin - #1142
Merged
Merged
Conversation
Member
Author
GCS upload inventory (done 2026-10-22)All objects below are on GCS at hash Required for
|
bl-young
added this pull request to stack #1143
October 22, 2026 18:20
Bump the committed FBS regen golden to the year-stem retained-activity parquet; drop the activity-collapse bridge in test_fbs. Leave USA model configs unchanged.
bl-young
force-pushed
the
by-fbs-pin-bump
branch
from
October 22, 2026 19:30
03070a5 to
fadf4e1
Compare
Member
Author
|
Integration tests pass on this stack ✅ |
catherinebirney
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @catherinebirney
Related: #1136, #1123
Stack: 2 of 2 (pin promote). Base: toolkit PR (
by-fbs-toolkit).What changed? Why?
Promotes the Cornerstone GHG FBS regeneration pin from the facilities-transportation NFT golden to the year-stem retained-activity object
GHG_national_Cornerstone_2024_v0.6.0_635777c.parquet(SHA256988e0e68…). Updatescornerstone_ghg_fbs_2024_pin.jsonand drops thefbs_regenerationactivity-collapse bridge now that both sides carryActivityProducedBy. Does not edit USA model configs.Impact
Weekday
fbs_regenerationcompares against the retained-activity year-stem golden; model loads viacornerstone_ghg_fbs_filenameare unchanged.Testing
Local rebuild matched prior-pin gas x sector; after uploading the 2024 GHG object to GCS, run
uv run pytest bedrock/transform/__tests__/test_fbs.py -m fbs_regeneration -v.Review focus
utils/config/configs/edits.Heads-up
GCS inventory (2024 GHG + full time-series siblings) is in the PR comment -- all uploaded. Config
cornerstone_ghg_fbs_filenameretarget is a follow-on.Evidence: this FBS vs last pinned FBS
GHG_national_Cornerstone_nowcast_facilities_transportation_2024_v0.5.0_82e24cd.parquetGHG_national_Cornerstone_2024_v0.6.0_635777c.parquetf88b3fe9…(committed pin)988e0e68a15d49d32a6cf7034c812425e417e5b9562f852856e99317dcc13857GHG_national_Cornerstone_2024ActivityProducedByGHGRP_sector_floordust rows on 33151 after activity collapse; immaterial to EWhat is not a gas/content delta: short year-stem name vs NFT name; tool/git hash
v0.6.0_635777cvsv0.5.0_82e24cd. Upstream Energy highway/distillate used in this rebuild match the prior Energy pins cellwise (max |d|=0) at the new hash.USA configs still point
cornerstone_ghg_fbs_filenameat the transportation NFT (…_82e24cd/ transport…_011f41f); only the regen pin JSON moves in this PR.