Conversation
…nd fresh-install schema
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…ion) Address Greptile/cubic review: - ARCHITECTURE.md: flag caller-supplied timestamp paths in the table (row.createdAt for compartment_chunk_embeddings, candidate.createdAt for primer_candidates, input.now for primers); add Notes covering the session-clone path (copySessionStateForClone preserves created_at verbatim) and the NOT NULL DEFAULT 0 backstop on ledger columns. - storage-db.ts: source_contents.created_at comment now reads "epoch ms; Date.now() on source writes, preserved on session clones". Docs/comments only; no behavior or migration changes.
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
updatePrimerAnswer() honors caller-supplied refreshedAt for primers.updated_at (default Date.now()); the table row previously listed only input.now. Docs only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #457, reshaped per maintainer feedback (magic-alfonso).
Changes
ARCHITECTURE.md — added a
### Timestamp Columnstable in the storage section listing eachcreated_at/updated_atcolumn with its unit (epoch ms) and the writer that stamps it. Every row was verified against its writer; columns with mixed writers (memorieshost/Rust-mirror) or non-TypeScript writers (workspaces, dashboard Rust) are called out explicitly rather than blanket-asserted.packages/plugin/src/features/magic-context/storage-db.ts — adds
-- epoch ms (Date.now())comments tocreated_atcolumns in the fresh-install schema only (no migration DDL touched — shipped migrations stay append-only). Only columns verified to be stamped byDate.now()get the comment;memories/workspacesare deliberately omitted.No behavior change. Not touching
migrations.tsper the maintainer's "applied migrations are history" note.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Documents the audited timestamp columns as epoch milliseconds in ARCHITECTURE.md and annotates verified fresh-install schema columns with their
Date.now()units. Clarifies timestamp handling without changing runtime behavior or migration history.row.createdAt,candidate.createdAt,input.now,refreshedAt), clone-preserved timestamps, and mixed (memories) or Rust (workspaces) writers.Date.now()is the actual writer.Written for commit 8d76de6. Summary will update on new commits.
Greptile Summary
Documents the units and provenance of audited timestamp columns without changing runtime behavior or migration history.
refreshedAt.Confidence Score: 5/5
The PR appears safe to merge because it only clarifies timestamp documentation and schema comments, with no outstanding correctness or repository-rule issues.
The prior timestamp-provenance concern was addressed and its thread is resolved; the subsequent
refreshedAtclarification accurately documents the remaining caller-supplied path.Important Files Changed
Reviews (3): Last reviewed commit: "docs: note refreshedAt override on prime..." | Re-trigger Greptile