Skip to content

fix(azure): default endpoint_suffix to blob.core.windows.net #7687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pujitha24 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(azure): default endpoint_suffix to blob.core.windows.net #7687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
378b83f
fix(azure): default endpoint_suffix to blob.core.windows.net
pujitha24 Jul 14, 2026
ae5d468
Regenerate config schema for azure endpoint_suffix default
pujitha24 Jul 15, 2026
9b6b60a
Merge branch 'master' into auto/issue-5449
friedrichg Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@
* [BUGFIX] Querier: Fix panic due to request tracker truncating multi-byte UTF-8 character #7640
* [BUGFIX] Ingester: Fix panic (`HistogramProtoToHistogram called with a float histogram`) when ingesting a float native histogram with a zero count (e.g. a staleness marker or empty histogram). The decoder is now selected by histogram type via `IsFloatHistogram()` instead of by count value. #7645
* [BUGFIX] Querier: Fix parquet queryable fallback returning a nil error instead of the actual query error in `LabelValues` and `LabelNames`. #7638
* [BUGFIX] Storage: Default the Azure `endpoint_suffix` to `blob.core.windows.net` instead of empty. Cortex builds the Thanos Azure config directly and bypasses Thanos' default, so an unset suffix produced an invalid FQDN (`<account>.`) and components hung on startup with DNS errors. #5449
* [BUGFIX] Store Gateway: Fix misleading "no index cache backend addresses" validation error being reported for chunks-cache, metadata-cache, and parquet caches when their memcached or redis backend is configured without addresses. The message is now the cache-type-agnostic "no cache backend addresses". #7675

## 1.21.0 2026-04-24
Expand Down
2 changes: 1 addition & 1 deletion docs/blocks-storage/querier.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ blocks_storage:
# Azure storage endpoint suffix without schema. The account name will be
# prefixed to this value to create the FQDN
# CLI flag: -blocks-storage.azure.endpoint-suffix
[endpoint_suffix: <string> | default = ""]
[endpoint_suffix: <string> | default = "blob.core.windows.net"]

# Number of retries for recoverable errors
# CLI flag: -blocks-storage.azure.max-retries
Expand Down
2 changes: 1 addition & 1 deletion docs/blocks-storage/store-gateway.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ blocks_storage:
# Azure storage endpoint suffix without schema. The account name will be
# prefixed to this value to create the FQDN
# CLI flag: -blocks-storage.azure.endpoint-suffix
[endpoint_suffix: <string> | default = ""]
[endpoint_suffix: <string> | default = "blob.core.windows.net"]

# Number of retries for recoverable errors
# CLI flag: -blocks-storage.azure.max-retries
Expand Down
8 changes: 4 additions & 4 deletions docs/configuration/config-file-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,7 @@ azure:
# Azure storage endpoint suffix without schema. The account name will be
# prefixed to this value to create the FQDN
# CLI flag: -alertmanager-storage.azure.endpoint-suffix
[endpoint_suffix: <string> | default = ""]
[endpoint_suffix: <string> | default = "blob.core.windows.net"]
Comment on lines 858 to +861

# Number of retries for recoverable errors
# CLI flag: -alertmanager-storage.azure.max-retries
Expand Down Expand Up @@ -1177,7 +1177,7 @@ azure:
# Azure storage endpoint suffix without schema. The account name will be
# prefixed to this value to create the FQDN
# CLI flag: -blocks-storage.azure.endpoint-suffix
[endpoint_suffix: <string> | default = ""]
[endpoint_suffix: <string> | default = "blob.core.windows.net"]

# Number of retries for recoverable errors
# CLI flag: -blocks-storage.azure.max-retries
Expand Down Expand Up @@ -6303,7 +6303,7 @@ azure:
# Azure storage endpoint suffix without schema. The account name will be
# prefixed to this value to create the FQDN
# CLI flag: -ruler-storage.azure.endpoint-suffix
[endpoint_suffix: <string> | default = ""]
[endpoint_suffix: <string> | default = "blob.core.windows.net"]

# Number of retries for recoverable errors
# CLI flag: -ruler-storage.azure.max-retries
Expand Down Expand Up @@ -6630,7 +6630,7 @@ azure:
# Azure storage endpoint suffix without schema. The account name will be
# prefixed to this value to create the FQDN
# CLI flag: -runtime-config.azure.endpoint-suffix
[endpoint_suffix: <string> | default = ""]
[endpoint_suffix: <string> | default = "blob.core.windows.net"]

# Number of retries for recoverable errors
# CLI flag: -runtime-config.azure.max-retries
Expand Down
2 changes: 1 addition & 1 deletion pkg/storage/bucket/azure/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func (cfg *Config) RegisterFlagsWithPrefix(prefix string, f *flag.FlagSet) {
f.Var(&cfg.StorageAccountKey, prefix+"azure.account-key", "Azure storage account key")
f.Var(&cfg.StorageConnectionString, prefix+"azure.connection-string", "The values of `account-name` and `endpoint-suffix` values will not be ignored if `connection-string` is set. Use this method over `account-key` if you need to authenticate via a SAS token or if you use the Azurite emulator.")
f.StringVar(&cfg.ContainerName, prefix+"azure.container-name", "", "Azure storage container name")
f.StringVar(&cfg.Endpoint, prefix+"azure.endpoint-suffix", "", "Azure storage endpoint suffix without schema. The account name will be prefixed to this value to create the FQDN")
f.StringVar(&cfg.Endpoint, prefix+"azure.endpoint-suffix", "blob.core.windows.net", "Azure storage endpoint suffix without schema. The account name will be prefixed to this value to create the FQDN")
Comment on lines 34 to +36
f.IntVar(&cfg.MaxRetries, prefix+"azure.max-retries", 20, "Number of retries for recoverable errors")
f.StringVar(&cfg.MSIResource, prefix+"azure.msi-resource", "", "Deprecated: Azure storage MSI resource. It will be set automatically by Azure SDK.")
f.StringVar(&cfg.UserAssignedID, prefix+"azure.user-assigned-id", "", "Azure storage MSI resource managed identity client Id. If not supplied default Azure credential will be used. Set it to empty if you need to authenticate via Azure Workload Identity.")
Expand Down
1 change: 1 addition & 0 deletions pkg/storage/bucket/azure/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (

// defaultConfig should match the default flag values defined in RegisterFlagsWithPrefix.
var defaultConfig = Config{
Endpoint: "blob.core.windows.net",
MaxRetries: 20,
Config: http.Config{
IdleConnTimeout: 90 * time.Second,
Expand Down
4 changes: 4 additions & 0 deletions schemas/cortex-config-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,7 @@
"x-cli-flag": "alertmanager-storage.azure.container-name"
},
"endpoint_suffix": {
"default": "blob.core.windows.net",
"description": "Azure storage endpoint suffix without schema. The account name will be prefixed to this value to create the FQDN",
"type": "string",
"x-cli-flag": "alertmanager-storage.azure.endpoint-suffix"
Expand Down Expand Up @@ -983,6 +984,7 @@
"x-cli-flag": "blocks-storage.azure.container-name"
},
"endpoint_suffix": {
"default": "blob.core.windows.net",
"description": "Azure storage endpoint suffix without schema. The account name will be prefixed to this value to create the FQDN",
"type": "string",
"x-cli-flag": "blocks-storage.azure.endpoint-suffix"
Expand Down Expand Up @@ -7803,6 +7805,7 @@
"x-cli-flag": "ruler-storage.azure.container-name"
},
"endpoint_suffix": {
"default": "blob.core.windows.net",
"description": "Azure storage endpoint suffix without schema. The account name will be prefixed to this value to create the FQDN",
"type": "string",
"x-cli-flag": "ruler-storage.azure.endpoint-suffix"
Expand Down Expand Up @@ -8229,6 +8232,7 @@
"x-cli-flag": "runtime-config.azure.container-name"
},
"endpoint_suffix": {
"default": "blob.core.windows.net",
"description": "Azure storage endpoint suffix without schema. The account name will be prefixed to this value to create the FQDN",
"type": "string",
"x-cli-flag": "runtime-config.azure.endpoint-suffix"
Expand Down