Skip to content

Skia AOT improvements, other updates and fixes - #182

Merged
cricketthomas merged 1 commit into
masterfrom
skia-aot
Oct 22, 2026
Merged

cricketthomas merged 1 commit into
masterfrom
skia-aot

Conversation

@cricketthomas

@cricketthomas cricketthomas commented Sep 13, 2026 •

Copy link
Copy Markdown
Owner
  • adds DynamicDependency to a bunch of attributes to avoid them being trimmed on skia aot builds
  • Localization still doesn't work on AOT
  • Bump uno version and winui versions
  • Fixes an issue where if you clicked directly on the tag when trying to open a new window, it would fail
  • update shared window code to use trackwindow as msft docs use, then closes it from the mainwindow, also fixes and issue with the theme of said window not working as expected
  • in the treeview, it was adding to a list, then updating the ui, now, it just adds it the UI rather than adding another collection

@cricketthomas
cricketthomas marked this pull request as ready for review September 19, 2026 01:34
add dep props
other cleanup
};

window.AppWindow.Closing += (s, e) =>
childWindow.Content = new NewItem()
private Window? _ownerWindow;
private bool _themeInitialized = false;
private bool _isDisposed = false;
private static bool _isDisposed = false;

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not sure if you know that. It will throw an exception, i tried not having that in there. I dont want it there

@@ -1,123 +1,61 @@
using AzureKeyVaultStudio.Services;
ResizeWindowScaled(childWindow.AppWindow, 640, 680);
else
window.AppWindow.Resize(new SizeInt32 { Width = 640, Height = 680 });
childWindow.AppWindow.Resize(new SizeInt32 { Width = 640, Height = 680 });
ResizeWindowScaled(childWindow.AppWindow, 640, 680);
else
window.AppWindow.Resize(new SizeInt32 { Width = 640, Height = 680 });
childWindow.AppWindow.Resize(new SizeInt32 { Width = 640, Height = 680 });
if (OperatingSystem.IsMacOS())
ResizeWindowScaled(window.AppWindow, 640, 680);
ResizeWindowScaled(childWindow.AppWindow, 640, 680);
if (OperatingSystem.IsMacOS())
ResizeWindowScaled(window.AppWindow, 640, 680);
ResizeWindowScaled(childWindow.AppWindow, 640, 680);
Comment thread src/uno/AzureKeyVaultStudio/App.xaml.cs Dismissed
@cricketthomas cricketthomas changed the title Skia AOT improvements Skia AOT improvements, other updates and fixes Oct 16, 2026

@cricketthomas cricketthomas left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed.

@cricketthomas
cricketthomas merged commit d761f78 into master Oct 22, 2026
@cricketthomas
cricketthomas deleted the skia-aot branch October 26, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants