Repository navigation
fix: let the direct-submission tests pass on a deployment's own schema - #112
Merged
Merged
Conversation
The direct-body tests compared the template's page fixture with the repository's own issue template and schema, which belong to the deployment; BCHC renames four questions, so its rc.9 update failed. They now build GitHub's side and the scaffolder's schema from the page's own questions. The signin_url test no longer assumes site.yml carries the key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
crypticpy
added a commit
that referenced
this pull request
Oct 13, 2026
* chore: release record for v1.11.0-rc.10 rc.9 failed closed in BCHC (run 38433343323) on three new tests that read the deployment's own schema and site.yml; nothing was published. rc.10 fixes those tests (#112) and otherwise carries rc.9 unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: record the rc.10 verify run at its exact commit Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BCHC's rc.9 update failed three new tests (run 38433343323) because they read deployment-owned data: the direct-body tests compared the template's page fixture with the repository's own issue template and schema (BCHC renames four questions), and the signin_url test assumed
site.ymlcarries the key.Test-only fix: the tests derive GitHub's side and the scaffolder schema from the page's own questions, in a temp checkout. Product code unchanged; a one-off proof on BCHC's built page confirmed
issueFormBodymatches GitHub's form body and the scaffolder reads both identically.Pinned verify passes in the template and in a BCHC overlay (BCHC's deployment-owned files over this branch).
🤖 Generated with Claude Code