Repository navigation
fix(editor): restore Find and missing editing shortcuts - #592
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused CodeMirror integration has regression coverage and no identified blocking issues; tests were not rerun here.
No open issues 🎉
What changed in this PR
Restores focused-editor Find and Replace and missing CodeMirror editing shortcuts across source editors and tool panes.
Changes:
- Adds shared search support and restores editing, folding, and diagnostic shortcuts.
- Styles editor panels and documents available shortcuts.
- Adds cross-platform browser regression coverage to local CI.
| File | Description |
|---|---|
src/styles/code-mirror-theme.ts |
Themes panels, controls, and search highlights. |
src/components/site-documents/keyboard-shortcuts.tsx |
Lists restored shortcuts in help. |
src/components/score-tools/code-pane.tsx |
Enables search and multiple selections. |
src/components/hot-keys/default-bindings.ts |
Removes an obsolete commented binding. |
src/components/editor/search.ts |
Defines shared search extensions. |
src/components/editor/editor.tsx |
Integrates search and restored keymaps. |
puppeteer-tests/tests/editor-find.js |
Tests search and editing shortcuts across platforms. |
puppeteer-tests/fixtures/editor-find.tsx |
Provides real editor components for regression tests. |
puppeteer-tests/fixtures/editor-find.html |
Hosts the responsive test fixture. |
package.json |
Declares the CodeMirror search dependency. |
package-lock.json |
Records the direct search dependency. |
docs/guide/reference/shortcuts.md |
Documents search behavior and editing shortcuts. |
.github/workflows/e2e-local.yml |
Adds the regression test to local CI. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cmd+F on macOS and Ctrl+F on Windows/Linux now open Find and Replace in the focused CodeMirror editor. The panel supports regex, case matching, whole words, and undoable replacement. It also works in tool panes, with replacement hidden for read-only output. Browser Find still works outside editors.
Restore the omitted shortcuts for next/previous match, selecting repeated text, go-to-line, code folding, error navigation, and deleting an empty bracket pair. Style the panels with the current theme and list the shortcuts in the help dialog and guide.
Validation: