Repository navigation
chore(settings): require an approval of the latest push on protected branches - #16
Merged
Merged
Conversation
…branches The markeli-agent bot opens pull requests with write access; one approval of the latest push keeps it from merging its own changes, including commits pushed after a review. Repository admins keep the bypass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
settings/rulesets/default-branch-pull-requests.json:required_approving_review_count0 → 1 andrequire_last_push_approval→ true for the default branch andrelease/*.Why
The
markeli-agentbot now opens pull requests with write access (e.g. in Curiosus.Migrations). With zero required approvals it could merge its own pull requests; with last-push approval it also can't push after a review and merge. Repository admins keep the bypass, so the owner's own pull requests still merge with "bypass rules". Sync and Dependabot pull requests are merged by hand already, nothing auto-merges.After merge
scripts/repo-settings.py applywith admin rights, thenscripts/repo-settings.py check.🤖 Generated with Claude Code