Skip to content

ci: fix shell injection in dependabot-review workflow #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agoldis merged 2 commits into from
Aug 17, 2026
Merged

ci: fix shell injection in dependabot-review workflow #173

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb4976a
ci: fix shell injection in dependabot-review workflow
agoldis Aug 16, 2026
2f48981
ci: gate dependabot review on PR author, not triggering actor
agoldis Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions .github/workflows/dependabot-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ on:
jobs:
cursor-agent-review:
name: Cursor Agent Dependency Review
if: startsWith(github.head_ref, 'dependabot/')
# Gate on the PR author, not the branch name: any fork can name a branch
# dependabot/... but only real Dependabot PRs are authored by dependabot[bot].
# Use pull_request.user.login rather than github.actor so a maintainer who
# reopens or pushes to the PR does not flip the actor and skip the review.
if: github.event.pull_request.user.login == 'dependabot[bot]' && startsWith(github.head_ref, 'dependabot/')
runs-on: ubuntu-latest
timeout-minutes: 35
permissions:
Expand All @@ -18,10 +22,11 @@ jobs:
id: launch
env:
CURSOR_API_KEY: ${{ secrets.CURSOR_API_KEY }}
# Pass PR fields through env, never inline ${{ }} in run: the title is
# attacker-controlled and would otherwise be executed as shell.
PR_URL: ${{ github.event.pull_request.html_url }}
PR_TITLE: ${{ github.event.pull_request.title }}
run: |
PR_URL="${{ github.event.pull_request.html_url }}"
PR_TITLE="${{ github.event.pull_request.title }}"

PROMPT=$(cat <<'PROMPT_EOF'
You are reviewing a Dependabot pull request for the currents-mcp repository.
This is a TypeScript MCP server located in the `mcp-server/` directory.
Expand Down Expand Up @@ -197,13 +202,14 @@ jobs:
env:
CURSOR_API_KEY: ${{ secrets.CURSOR_API_KEY }}
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
# Pass interpolated values through env, never inline ${{ }} in run:
# PR_TITLE is attacker-controlled; the rest follow the same rule.
AGENT_ID: ${{ steps.launch.outputs.agent_id }}
AGENT_URL: ${{ steps.launch.outputs.agent_url }}
AGENT_STATUS: ${{ steps.poll.outputs.status }}
PR_URL: ${{ github.event.pull_request.html_url }}
PR_TITLE: ${{ github.event.pull_request.title }}
run: |
AGENT_ID="${{ steps.launch.outputs.agent_id }}"
AGENT_URL="${{ steps.launch.outputs.agent_url }}"
AGENT_STATUS="${{ steps.poll.outputs.status }}"
PR_URL="${{ github.event.pull_request.html_url }}"
PR_TITLE="${{ github.event.pull_request.title }}"

SUMMARY=""
if [ -n "$AGENT_ID" ] && [ "$AGENT_ID" != "null" ]; then
SUMMARY=$(curl -s -u "$CURSOR_API_KEY:" \
Expand Down
Loading