Skip to content

testOctaveIsImplicit uses a mock for the Note - #2073

Merged
mscuthbert merged 1 commit into
masterfrom
test-octave-implicit-mock
Oct 8, 2026
Merged

mscuthbert merged 1 commit into
masterfrom
test-octave-implicit-mock

Conversation

@mscuthbert

Copy link
Copy Markdown
Member

testOctaveIsImplicit checks whether the Note is told about a pitch change by mocking pitchChanged, as testPsAndMidiSettersInformNoteOnce (#2071) does, instead of putting a junk entry in the Note's _cache.

AI-assisted (Claude)

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 93.371%. remained the same — test-octave-implicit-mock into master

@mscuthbert
mscuthbert marked this pull request as ready for review October 8, 2026 20:40
@mscuthbert
mscuthbert merged commit b09189c into master Oct 8, 2026
8 checks passed
@mscuthbert
mscuthbert deleted the test-octave-implicit-mock branch October 8, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants