Repository navigation
Import better m21p Chord root() functions - #343
Merged
Merged
Conversation
m21j's root search only checked the 3rd and 5th and fell back to the lowest pitch, so e.g. G4 C5 had root G (m21p: C, 2nd inversion), and the stacked-thirds result was never cached. Now uses m21p's stacked- thirds fast path, rootness scoring, and bass-as-root for 13ths. root() also takes a string or Note, snaps to a matching chord pitch, and has m21p's `find` option. Empty chords throw "no pitches in chord". AI-assisted (Claude)
AI-assisted (Claude)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
music21p had a more sophisticated
root()function -- use it here also. Now will find roots properly for missing thirds in 7th chords, etc.AI-Assisted (Claude)