Repository navigation
🔧 chore(deps): override http-cache-semantics to 4.3.0 in site/ - #203
Conversation
cwest
left a comment
There was a problem hiding this comment.
The override itself is right. http-cache-semantics is pinned to 4.3.0 in site/package.json following the existing overrides pattern, the lockfile is regenerated cleanly, and the 4.2.0 tarball is fully gone — the installed tree resolves http-cache-semantics@4.3.0 overridden, which takes it outside the advisory's <= 4.2.0 range. Verified from a fresh checkout of the head: npm ci 0 vulnerabilities, npm run build green (11 pages), npm test 41/41, npm audit --omit=dev and full npm audit both 0. No Go touched.
One thing to fix before this can land: the branch is a commit behind main (the goreleaser-action bump landed after it was cut), and main requires branches to be up to date before merge, so GitHub currently reports the merge state as behind rather than clean. Update the branch onto current main and push — no code change, just the rebase — and the merge path goes green.
8aaf8b5 to
b850fec
Compare
The site resolves http-cache-semantics 4.2.0 transitively via astro, which falls inside advisory GHSA-rc47-6667-2j5j's affected range (<= 4.2.0). npm now publishes 4.3.0, outside that range. Pin it via site/package.json `overrides` (same pattern used for zod/undici/postcss-selector-parser) and regenerate the lockfile. Verified in site/: npm ci, npm run build, and npm test (41 pass) green; npm audit --omit=dev reports 0 vulnerabilities. Zero Go changes.
b850fec to
7d8eb79
Compare
cwest
left a comment
There was a problem hiding this comment.
The branch is current on main now and the merge state is clean. Re-verified from a fresh checkout of the head: the override pins http-cache-semantics to 4.3.0 and the lockfile resolves 4.3.0 with no 4.2.0 tarball references left. npm ci, build (11 pages), and the test suite (41 passing) are all green, and both npm audit --omit=dev and the full audit report zero vulnerabilities. The diff is exactly the two site/ files with no Go touched. No changes needed.
Why
Dependabot alert #11 (http-cache-semantics, high,
site/package-lock.json) wasleft open by #202 on the premise that no patched version existed. The advisory
range is
<= 4.2.0; npm now publishes 4.3.0, which is outside that range.The site resolved 4.2.0 transitively via astro.
What
Pin
http-cache-semanticsto4.3.0insite/package.jsonoverrides(samepattern #202 used for zod/undici/postcss-selector-parser) and regenerate the
lockfile. Two files change; zero Go changes.
Verification (run output, in
site/)Resolved version, before → after:
Go untouched;
CGO_ENABLED=0 go build .OK.Done when
cd site && npm ci && npm run build && npm testgreen; built site renders.npm audit --omit=devreports 0 vulnerabilities.(advisory
first_patched_versionis null), dismissed as fixed with a link tothis PR, noted on the card.