Skip to content

🔧 chore(deps): override http-cache-semantics to 4.3.0 in site/ - #203

Merged
cwest merged 2 commits into
mainfrom
wt/t_134435a0-chore-deps-s-override-http-cache-semanti
Oct 28, 2026
Merged

cwest merged 2 commits into
mainfrom
wt/t_134435a0-chore-deps-s-override-http-cache-semanti

Conversation

@cwest

@cwest cwest commented Oct 28, 2026

Copy link
Copy Markdown
Owner

Why

Dependabot alert #11 (http-cache-semantics, high, site/package-lock.json) was
left open by #202 on the premise that no patched version existed. The advisory
range is <= 4.2.0; npm now publishes 4.3.0, which is outside that range.
The site resolved 4.2.0 transitively via astro.

What

Pin http-cache-semantics to 4.3.0 in site/package.json overrides (same
pattern #202 used for zod/undici/postcss-selector-parser) and regenerate the
lockfile. Two files change; zero Go changes.

Verification (run output, in site/)

Resolved version, before → after:

before: node_modules/http-cache-semantics -> 4.2.0
after:  node_modules/http-cache-semantics -> 4.3.0
grep http-cache-semantics-4.2.0 package-lock.json -> 0 hits
$ npm ci
added 293 packages, and audited 294 packages
found 0 vulnerabilities

$ npm run build
[build] 11 page(s) built in 2.09s
[build] Complete!

$ npm test
ℹ tests 41
ℹ pass 41
ℹ fail 0

$ npm audit --omit=dev
found 0 vulnerabilities

$ npm audit
found 0 vulnerabilities

Go untouched; CGO_ENABLED=0 go build . OK.

Done when

  • cd site && npm ci && npm run build && npm test green; built site renders.
  • npm audit --omit=dev reports 0 vulnerabilities.
  • Full repo CI green. Zero Go changes.
  • After merge, alert feat(search): WordPiece tokenizer + --embedder model2vec (increment 5c-2) #11 closed — or, if Dependabot will not auto-close
    (advisory first_patched_version is null), dismissed as fixed with a link to
    this PR, noted on the card.

@cwest cwest left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The override itself is right. http-cache-semantics is pinned to 4.3.0 in site/package.json following the existing overrides pattern, the lockfile is regenerated cleanly, and the 4.2.0 tarball is fully gone — the installed tree resolves http-cache-semantics@4.3.0 overridden, which takes it outside the advisory's <= 4.2.0 range. Verified from a fresh checkout of the head: npm ci 0 vulnerabilities, npm run build green (11 pages), npm test 41/41, npm audit --omit=dev and full npm audit both 0. No Go touched.

One thing to fix before this can land: the branch is a commit behind main (the goreleaser-action bump landed after it was cut), and main requires branches to be up to date before merge, so GitHub currently reports the merge state as behind rather than clean. Update the branch onto current main and push — no code change, just the rebase — and the merge path goes green.

@cwest
cwest force-pushed the wt/t_134435a0-chore-deps-s-override-http-cache-semanti branch 2 times, most recently from 8aaf8b5 to b850fec Compare October 28, 2026 20:04
The site resolves http-cache-semantics 4.2.0 transitively via astro, which
falls inside advisory GHSA-rc47-6667-2j5j's affected range (<= 4.2.0).
npm now publishes 4.3.0, outside that range. Pin it via site/package.json
`overrides` (same pattern used for zod/undici/postcss-selector-parser) and
regenerate the lockfile.

Verified in site/: npm ci, npm run build, and npm test (41 pass) green;
npm audit --omit=dev reports 0 vulnerabilities. Zero Go changes.
@cwest
cwest force-pushed the wt/t_134435a0-chore-deps-s-override-http-cache-semanti branch from b850fec to 7d8eb79 Compare October 28, 2026 20:09

@cwest cwest left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch is current on main now and the merge state is clean. Re-verified from a fresh checkout of the head: the override pins http-cache-semantics to 4.3.0 and the lockfile resolves 4.3.0 with no 4.2.0 tarball references left. npm ci, build (11 pages), and the test suite (41 passing) are all green, and both npm audit --omit=dev and the full audit report zero vulnerabilities. The diff is exactly the two site/ files with no Go touched. No changes needed.

@cwest
cwest marked this pull request as ready for review October 28, 2026 20:16
@cwest
cwest merged commit 0899f22 into main Oct 28, 2026
10 checks passed
@cwest
cwest deleted the wt/t_134435a0-chore-deps-s-override-http-cache-semanti branch October 28, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant