Skip to content

πŸ”§ chore(ci): bump Go toolchain 1.26.10 β†’ 1.26.11 for GO-2026-6859 - #214

Open
cwest wants to merge 1 commit into
mainfrom
topic/bump-go-1-26-11
Open

cwest wants to merge 1 commit into
mainfrom
topic/bump-go-1-26-11

Conversation

@cwest

@cwest cwest commented Nov 15, 2026

Copy link
Copy Markdown
Owner

Why

govulncheck (run inline in the required build-test check, pulling the live vuln DB) reports GO-2026-6859 against net/http@go1.26.10 β€” an HTTP/1 server crash from a MaxBytesReader header race, fixed in net/http@go1.26.11. The advisory was disclosed 2026-11-11, so it turned build-test red repo-wide β€” including on an unmodified main β€” blocking every open PR under strict branch protection. This is a standard-library advisory, not a code defect in any PR.

What

Bump the Go toolchain to the fix release 1.26.11 across every surface:

  • go.mod β€” go 1.26.10 β†’ 1.26.11 (no separate toolchain directive present)
  • .github/workflows/{ci,release,codeql,govulncheck}.yml β€” every setup-go go-version: '1.26.10' β†’ '1.26.11' (8 occurrences total; ci.yml has 4)
  • CHANGELOG.md β€” a ### Build entry under [Unreleased], matching the house pattern of the prior 1.26.6β†’1.26.10 entry

No code or behavior change beyond the version bump.

Verification (run locally under go1.26.11)

Root cause proven both directions:

toolchain govulncheck ./...
go1.26.10 (what CI uses today) Vulnerability #1: GO-2026-6859 … Fixed in: net/http@go1.26.11
go1.26.11 (this PR) No vulnerabilities found.

Under go1.26.11:

  • govulncheck ./... β†’ No vulnerabilities found (GO-2026-6859 cleared)
  • gofmt -l . β†’ clean
  • go vet ./... β†’ clean
  • go build ./... β†’ clean
  • go test ./internal/okf/ ./cmd/ -run Conformance -race β†’ pass (spec-conformance gate)
  • go test ./... -race β†’ all packages pass
  • binary smoke: okfctl --version / --help run clean

Done when

  • govulncheck ./... no longer reports GO-2026-6859 on main βœ… (verified)
  • Required build-test check goes green (expected once CI runs the new head)
  • No code/behavior changes beyond the toolchain/version bump βœ…

govulncheck (run inline in the required build-test check, pulling the live
vuln DB) reports GO-2026-6859 against net/http@go1.26.10 β€” an HTTP/1 server
crash from a MaxBytesReader header race, fixed in net/http@go1.26.11. The
advisory was disclosed 2026-11-11, so it turned the build-test check red
repo-wide, including on an unmodified main, blocking every open PR under
strict branch protection.

Bump the toolchain to the fix release 1.26.11 across every surface: the
go.mod go directive and the setup-go go-version in all four workflows (ci,
release, codeql, govulncheck). Verified locally under go1.26.11: govulncheck
./... reports no vulnerabilities, and gofmt/go vet/go build/go test ./...
-race are all clean. No code or behavior change beyond the version bump.

@cwest cwest left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes needed.

This does exactly what it says: bumps the Go toolchain from 1.26.10 to 1.26.11 across go.mod and the setup-go step in all four workflows, with a matching CHANGELOG entry. Nothing else moves.

I reproduced the advisory both ways against this tree. On base main under go1.26.10, govulncheck reports GO-2026-6859 in net/http, fixed in 1.26.11. On this branch under go1.26.11, govulncheck comes back clean. The CHANGELOG description of the bug (an HTTP/1 MaxBytesReader header race) matches the upstream advisory. gofmt, go vet, go build, and go test ./... -race are all green under 1.26.11, and there's no behavior change beyond the version strings.

The four required checks (build-test, lint, analyze (go), site) are green; build-test, the one this is meant to unblock, is back to passing. The skill-contract check is red, but it's red on unmodified main too, from a 403 off the okfctl.dev install path, so it's unrelated to this change and isn't a required check.

@cwest
cwest marked this pull request as ready for review November 15, 2026 17:10

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant